Mark Striemer [:mstriemer] Assignee
	Description • 6 years ago

The Tab Hiding API is behind a pref that is now false. Once the UI is landed and passes QA we would like to enable the API by default.

Flip extensions.webextensions.tabhide.enabled to true to enable the API.

	brunoais
	Comment 1 • 6 years ago

Please confirm if this is actually P2 or if it really is P3. From my understanding of the current state, it is a P3.

	Shane Caraveo (:mixedpuppy)
	Comment 3 • 6 years ago
mozreview-review

Comment on attachment 8972736 [details]
Bug 1455040 - Enable tab hiding API by default

https://reviewboard.mozilla.org/r/241260/#review247144

Also post a followup bug for the pref removal, maybe for 62.

	Mark Striemer [:mstriemer] Assignee
	Comment 4 • 6 years ago

This is really a P2 or maybe a P1. Either way it's being actively looked at.

	:shell escalante
	Comment 5 • 6 years ago

Hi Mark,

Please land this bug and request uplift to Beta.  All the reviews of the bugs still to be fixed, determined they are not blocking for this API to go int0 61.

	Pulsebot
	Comment 6 • 6 years ago

Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0f3ca662619
Enable tab hiding API by default r=mixedpuppy

	Mark Striemer [:mstriemer] Assignee
	Comment 7 • 6 years ago

Comment on attachment 8972736 [details]
Bug 1455040 - Enable tab hiding API by default

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: The webextensions Tab Hiding API is not enabled by default.
[Is this code covered by automated tests?]: The Tab Hiding API is covered by automated tests
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: I believe this has been done in other bugs
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Tested by QE, pref flip to enable a feature
[String changes made/needed]: No

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 6 years ago

Comment on attachment 8972736 [details]
Bug 1455040 - Enable tab hiding API by default

Feature status looks good, approved for 61.0b3.

	Mark Striemer [:mstriemer] Assignee
	Comment 9 • 6 years ago

Looks like there was a test that needed to be updated. Here's a patch that updates it. I can squash the two together if needed

	Shane Caraveo (:mixedpuppy)
	Comment 11 • 6 years ago
mozreview-review

Comment on attachment 8972736 [details]
Bug 1455040 - Enable tab hiding API by default

https://reviewboard.mozilla.org/r/241260/#review247936

::: browser/components/extensions/test/browser/browser_ext_tabs_hide.js:43
(Diff revision 2)
>    await SpecialPowers.pushPrefEnv({
>      set: [["extensions.webextensions.tabhide.enabled", true]],
>    });

Lets remove these as well. (all other tests have it)

	Pulsebot
	Comment 12 • 6 years ago

Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74093e23efd0
Backed out changeset c0f3ca662619 for failing on extensions/test/browser/browser_ext_tabs_hide.js on a CLOSED TREE

	Mozilla Autoland
	Comment 15 • 6 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2fe29e59bde19bf956baa49811d244618cd0a411 -d 61d7c365ea76: rebasing 462416:2fe29e59bde1 "Bug 1455040 - Enable tab hiding API by default r=mixedpuppy" (tip)
merging browser/components/extensions/test/browser/browser_ext_tabs_hide.js
merging modules/libpref/init/all.js
warning: conflicts while merging browser/components/extensions/test/browser/browser_ext_tabs_hide.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

	Pulsebot
	Comment 17 • 6 years ago

Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/318f17dbfa9f
Enable tab hiding API by default r=mixedpuppy

	Raul Gurzau (:RaulG)
	Comment 18 • 6 years ago

Backed out changeset c0f3ca662619 (bug 1455040) for failing on extensions/test/browser/browser_ext_tabs_hide.js on a CLOSED TREE 

Backout link: https://hg.mozilla.org/integration/autoland/rev/74093e23efd085e2637bd93cc5a1d4c13ddfc9f3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c0f3ca662619707d531139d9c0b73778362ccf2b

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=177282079&repo=autoland&lineNumber=3548

Log snippet: 

[task 2018-05-07T16:32:01.612Z] 16:32:01     INFO - TEST-START | browser/components/extensions/test/browser/browser_ext_tabs_hide.js
[task 2018-05-07T16:32:01.718Z] 16:32:01     INFO - TEST-INFO | started process screentopng
[task 2018-05-07T16:32:02.272Z] 16:32:02     INFO - TEST-INFO | screentopng: exit 0
[task 2018-05-07T16:32:02.274Z] 16:32:02     INFO - Buffered messages logged at 16:32:01
[task 2018-05-07T16:32:02.275Z] 16:32:02     INFO - Entering test bound test_pref_disabled
[task 2018-05-07T16:32:02.276Z] 16:32:02     INFO - Extension loaded
[task 2018-05-07T16:32:02.278Z] 16:32:02     INFO - Console message: Warning: attempting to write 20593 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2018-05-07T16:32:02.279Z] 16:32:02     INFO - Buffered messages finished
[task 2018-05-07T16:32:02.281Z] 16:32:02     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_hide.js | Promise resolved, expected rejection: Got the expected error when pref not enabled -

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 6 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/22c0edf133aa

	Arthur Iakab [arthur_iakab]
	Comment 20 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/318f17dbfa9f

	CosminB
	Comment 21 • 6 years ago

This bug is verified as fixed on Firefox 61.0b3 (20180503095637) and Firefox 62.0a1 (20180508231737) under Win 7 64-bit and Mac OS X 10.13.3.

The preference “extensions.webextensions.tabhide.enabled” is enabled to true by default.

	Will Bamberg [:wbamberg]
	Comment 23 • 6 years ago

Removed the "experimental" note from the top of the page, and the flag from the compat table: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/hide

Please let me know if you need anything else here.

	kernp25
	Comment 24 • 6 years ago

What about tabs.show?

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/show

	Will Bamberg [:wbamberg]
	Comment 25 • 6 years ago

Oh, sorry I missed that. I can update the page right away, but the compat data will take longer...

	Mark Striemer [:mstriemer] Assignee
	Comment 26 • 6 years ago

This looks good to me, thanks!

One comment on the tabs.hide() function. It recommends that you discard a tab when it is hidden which would make sense for some cases but I'm not sure that it would be the "recommended" way in all cases. Tab groups, for example, likely wouldn't want to discard an entire group when you switch away since you might want to go back and forth frequently or have music playing in the background.

Perhaps noting that discarding will free the resources without recommending it would be better?

	Will Bamberg [:wbamberg]
	Comment 27 • 6 years ago

Thanks for the review Mark, your comment makes sense to me and I've tried updating the doc accordingly.