Closed Bug 1453518 Opened 6 years ago Closed 5 years ago

Crash in nssCertificate_Destroy | CERT_DestroyCertArray | NSS_CMSSignedData_ImportCerts | nsCMSMessage::CommonVerifySignature when downloading mail

Categories

(Thunderbird :: Security, defect)

Unspecified
Windows 10
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Robert_Hartmann, Unassigned)

References

Details

(Keywords: crash, testcase-wanted, topcrash)

Crash Data

Attachments

(1 file)

Daily TB thunderbird-61.0a1.en-US.win64

Windows 10 64bit

===============
This bug was filed from the Socorro interface and is
report bp-739e2c48-425c-4d8d-b8fa-c0d4f0180411.
=============================================================

Top 10 frames of crashing thread:

0 nss3.dll nssCertificate_Destroy security/nss/lib/pki/certificate.c:95
1 nss3.dll CERT_DestroyCertArray security/nss/lib/certdb/certdb.c:2232
2 nss3.dll NSS_CMSSignedData_ImportCerts security/nss/lib/smime/cmssigdata.c:635
3 xul.dll nsCMSMessage::CommonVerifySignature C:/builds/moz2_slave/tb-c-cen-w64-ntly-000000000000/build/mailnews/mime/src/nsCMS.cpp:227
4 xul.dll mozilla::CryptoTask::Run security/manager/ssl/CryptoTask.cpp:39
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1096
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:517
7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:334
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:319
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:299

=============================================================
This is quite close to bug 1386601. The source line numbers for frame 0 and 2 are the same
Component: Untriaged → Security
See Also: → 1386601
Walt this is the crash you have been seeing, for example bp-cd5efce0-22a7-4032-9797-4b4030180415. Any insights?
or perhaps bug 1386601?
Flags: needinfo?(wls220spring)
Keywords: crash
Yes, it is what I saw with my Comcast account when creating it for testing.

Sorry, no insights.

The latest happened after downloading Comcast mail, using my production profile on Windows, after I had not used it for a few days. https://crash-stats.mozilla.com/report/index/bp-58c7a1d5-b778-4f5a-905a-09bf70180608. Bug 1386601 is related to that crash.
Flags: needinfo?(wls220spring)
Just a thought.

Looking at Troubleshooting Information, Firefox 60.0.2 release has the "Expected minimum versions" of NSS, NSSSMIME, NSSSSL and NSSUTIL at 3.36.4. In TB 60 beta they are version 3.36.1.

Maybe an update to version 3.36.4 would help?
#12 crash signature in Thunderbird 60.  Let's hitch our wagon to #1 crash bug 1386601

Robert are you still able to reproduce?
Status: UNCONFIRMED → NEW
Depends on: 1386601
Ever confirmed: true
Flags: needinfo?(Robert_Hartmann)
Keywords: topcrash
This user jons crashes quite often  bp-65731f71-21fe-4039-a3dd-997a10180726 for example

Crashing Thread (59), Name: SMimeVerify
Frame 	Module 	Signature 	Source
0 	libnss3.so 	nssCertificate_Destroy 	security/nss/lib/pki/certificate.c:95
1 	libnss3.so 	CERT_DestroyCertArray 	security/nss/lib/certdb/certdb.c:2232
2 	libsmime3.so 	NSS_CMSSignedData_ImportCerts 	security/nss/lib/smime/cmssigdata.c:635
3 	libxul.so 	nsCMSMessage::CommonVerifySignature(unsigned char*, unsigned int) 	comm/mailnews/mime/src/nsCMS.cpp:224
4 	libxul.so 	mozilla::CryptoTask::Run() 	security/manager/ssl/CryptoTask.cpp:39
Summary: Crash in nssCertificate_Destroy | CERT_DestroyCertArray | NSS_CMSSignedData_ImportCerts | nsCMSMessage::CommonVerifySignature → Crash in nssCertificate_Destroy | CERT_DestroyCertArray | NSS_CMSSignedData_ImportCerts | nsCMSMessage::CommonVerifySignature when downloading mail
(In reply to Wayne Mery (:wsmwk) from comment #6)
> #12 crash signature in Thunderbird 60.  Let's hitch our wagon to #1 crash
> bug 1386601
> 
> Robert are you still able to reproduce?

Sorry ... cannot reproduce it. 
Perhaps if I can localise an recieved S/MINE Mail ... 
but how I can filter my IMAP-Inboxes only to show S/MIME Mails?

(With new daily I recieved an shutdown crash - Bug 1484596 )
Flags: needinfo?(Robert_Hartmann) → needinfo?(vseerror)
> but how I can filter my IMAP-Inboxes only to show S/MIME Mails?

perhaps magnus will have an idea
Flags: needinfo?(vseerror) → needinfo?(mkmelin+mozilla)
I don't think there's a direct way through the UI. 
They show the secure icon in the mail header when viewed though.
Flags: needinfo?(mkmelin+mozilla)
Perhaps use https://addons.thunderbird.net/en-US/thunderbird/addon/importexporttools/ to export all the emails as files, then search or grep them in Windows
(In reply to WaltS48 [:walts48] from comment #5)
> Just a thought.
> 
> Looking at Troubleshooting Information, Firefox 60.0.2 release has the
> "Expected minimum versions" of NSS, NSSSMIME, NSSSSL and NSSUTIL at 3.36.4.
> In TB 60 beta they are version 3.36.1.
> 
> Maybe an update to version 3.36.4 would help?

Let's first test the theory - Robert, can you test a nightly build? (We don't yet have a 63 beta, otherwise we'd test a beta)
https://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-central/
Flags: needinfo?(Robert_Hartmann)
Keywords: testcase-wanted
Is TB 64.0a1 (2018-10-03) (64-bit) on Win10 64bit okay for your theory?
Flags: needinfo?(Robert_Hartmann) → needinfo?(vseerror)
Okay I found an e-mail (from year 2012) having 
Content-Type: application/pkcs7-signature; name=smime.p7s
using TB 64.0a1 (2018-10-03) (64-bit) on Win10 64bit.

If I double click on the envelope (having a white cross on red filled circle)
than a new empty Window opened with title "Message Security". (see attachement)
(In reply to Robert Hartmann from comment #13)
> Is TB 64.0a1 (2018-10-03) (64-bit) on Win10 64bit okay for your theory?

Yes.  Also 63 beta is out https://www.thunderbird.net/en-US/channel/
Flags: needinfo?(vseerror)
(In reply to WaltS48 [:walts48] from comment #5)
> Just a thought.
> 
> Looking at Troubleshooting Information, Firefox 60.0.2 release has the
> "Expected minimum versions" of NSS, NSSSMIME, NSSSSL and NSSUTIL at 3.36.4.
> In TB 60 beta they are version 3.36.1.
> 
> Maybe an update to version 3.36.4 would help?

bug 1192778 also might depend on NSS fixes, where I've posted the reporter's more recent crash reports point to bug 1461731 (which should be in  NSS 3.38 Firefox 62, NSS 3.37.2 for Firefox 61, NSS 3.36.3 for Firefox 60 ESR and potentially 60.0.2 - and corresponding versions of Thunderbird?) ... except that bug 1461731 was a more recent regression.
Walt do you have a reproducible testcase for this?
Flags: needinfo?(wls220spring)
(In reply to Wayne Mery (:wsmwk) from comment #17)
> Walt do you have a reproducible testcase for this?

Sorry, I don't.

I haven't had any crashes like this since this one with 60.0b6.

https://crash-stats.mozilla.com/report/index/58c7a1d5-b778-4f5a-905a-09bf70180608#tab-bugzilla
Flags: needinfo?(wls220spring)

With the patch in bug 1386601, and the uplift to 60.5.2, there are no more crashes

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: