Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Description • 6 years ago

There is a "ElementTap" command present in both geckodriver and webdriver. But there is nothing like that listed in the WebDriver spec. In Marionette it calls `singleTap`, which is part of the old action API.

Not sure when or why this has been added in the past. Maybe it was part of the spec at an earlier stage?

Andreas, am I correct that this can be removed?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 6 years ago

This can probably be removed.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 2 • 6 years ago

Great. So all references to this command can then be removed from any of the files under `testing/geckodriver` and `testing/webdriver`.

	Kerem Kat
	Comment 3 • 6 years ago

Here is a patch removing ElementTap.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 4 • 6 years ago

Comment on attachment 8967982 [details] [diff] [review]
0001-1-remove-ElementTap.patch

Review of attachment 8967982 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks fine and you should have covered each instance of ElementTap. But the commit message is incorrect because it references Marionette, and not geckodriver.

Also maybe you could push your updated patch to mozreview? That would be fantastic because then I could easily create a try build to verify the changes. Thanks.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 6 years ago

Do you have time and ability to fix up the patch?

	Kerem Kat
	Comment 6 • 6 years ago

Unfortunately, not currently.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 7 • 6 years ago

Andreas, given that it was only the commit message which is wrong, maybe you can update and trigger a try build?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 8 • 6 years ago

Removes the non-standard /session/{session id}/element/{element
id}/tap endpoint command from geckodriver.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 9 • 6 years ago

Comment on attachment 9012046 [details]
bug 1453292: webdriver, geckodriver: remove elementTap command

Henrik Skupin (:whimboo) has approved the revision.

	Pulsebot
	Comment 10 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3ad3c9327b9
webdriver, geckodriver: remove elementTap command r=whimboo

	Stefan Hindli [:stefan_hindli]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f3ad3c9327b9