Closed Bug 1453148 Opened 6 years ago Closed 6 years ago

Make `overflow` take two values

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(
URL
)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1453148: Let overflow parse two values.
59 bytes, text/x-review-board-request
xidorn
: review+
Details 
Comment on attachment 8966768 [details]
Bug 1453148: Let overflow parse two values.

https://reviewboard.mozilla.org/r/235452/#review241150

Please send an "Intent to ship".

::: testing/web-platform/tests/css/css-overflow/overflow-shorthand-001.html:7
(Diff revision 1)
> +<meta charset="utf-8">
> +<title>CSS Overflow Test: Overflow longhand accepts two values</title>
> +<script src="/resources/testharness.js"></script>
> +<script src="/resources/testharnessreport.js"></script>
> +<link rel="author" title="Emilio Cobos Álvarez <emilio@crisal.io>">
> +<link rel="help" href="https://drafts.csswg.org/css-overflow/#propdef-overflow">

`css-overflow-3`
Attachment #8966768 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/84fc374da5e3
Let overflow parse two values. r=xidorn
Backed out changeset 84fc374da5e3 (bug 1453148) for mochitest failures on layout/style/test/test_bug319381.html

Backout: https://hg.mozilla.org/integration/autoland/rev/bc2413bb322f84d3fb13dd9a17ca57fc2b8d4aaf

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=84fc374da5e3e01050664b3e3c34301a5eaea4c6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=173211868

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173211868&repo=autoland

[task 2018-04-12T06:32:35.908Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.910Z] 06:32:35     INFO - Buffered messages finished
[task 2018-04-12T06:32:35.911Z] 06:32:35     INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_bug319381.html | Shorthand read directly - got "hidden scroll", expected ""
[task 2018-04-12T06:32:35.912Z] 06:32:35     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T06:32:35.913Z] 06:32:35     INFO -     @layout/style/test/test_bug319381.html:46:1
[task 2018-04-12T06:32:35.914Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand computed 
[task 2018-04-12T06:32:35.917Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand as CSSValue 
[task 2018-04-12T06:32:35.918Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.919Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.921Z] 06:32:35     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-12T06:32:35.926Z] 06:32:35     INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_bug319381.html | Shorthand read directly - got "scroll hidden", expected ""
[task 2018-04-12T06:32:35.926Z] 06:32:35     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T06:32:35.927Z] 06:32:35     INFO -     @layout/style/test/test_bug319381.html:53:1
[task 2018-04-12T06:32:35.928Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand computed 
[task 2018-04-12T06:32:35.930Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand as CSSValue 
[task 2018-04-12T06:32:35.932Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.933Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.934Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand serialization 
[task 2018-04-12T06:32:35.936Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand computation 
[task 2018-04-12T06:32:35.937Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Shorthand computation as CSSValue 
[task 2018-04-12T06:32:35.940Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.941Z] 06:32:35     INFO - TEST-PASS | layout/style/test/test_bug319381.html | Roundtrip 
[task 2018-04-12T06:32:35.941Z] 06:32:35     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-12T06:32:35.943Z] 06:32:35     INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_bug319381.html | Shorthand serialization - got "visible hidden", expected ""
Flags: needinfo?(emilio)
and some android-opt-mochitest failures:

300 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property - got "-moz-hidden-unscrollable", expected ""

https://treeherder.mozilla.org/logviewer.html#?job_id=173211944&repo=autoland&lineNumber=2603

[task 2018-04-12T07:05:35.190Z] 07:05:35     INFO -  300 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.190Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.190Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:29:3
[task 2018-04-12T07:05:35.191Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:99:7
[task 2018-04-12T07:05:35.191Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
[task 2018-04-12T07:05:35.192Z] 07:05:35     INFO -  301 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property when testing subproperty 'overflow-x' - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.193Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.194Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:36:7
[task 2018-04-12T07:05:35.194Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:99:7
[task 2018-04-12T07:05:35.195Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
[task 2018-04-12T07:05:35.196Z] 07:05:35     INFO -  302 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property when testing subproperty 'overflow-y' - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.196Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.197Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:36:7
[task 2018-04-12T07:05:35.198Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:99:7
[task 2018-04-12T07:05:35.198Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
[task 2018-04-12T07:05:35.199Z] 07:05:35     INFO -  303 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.199Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.200Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:29:3
[task 2018-04-12T07:05:35.200Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:101:7
[task 2018-04-12T07:05:35.200Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
[task 2018-04-12T07:05:35.202Z] 07:05:35     INFO -  304 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property when testing subproperty 'overflow-x' - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.202Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.202Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:36:7
[task 2018-04-12T07:05:35.202Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:101:7
[task 2018-04-12T07:05:35.203Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
[task 2018-04-12T07:05:35.204Z] 07:05:35     INFO -  305 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | invalid value '-moz-hidden-unscrollable -moz-hidden-unscrollable' not accepted for 'overflow' property when testing subproperty 'overflow-y' - got "-moz-hidden-unscrollable", expected ""
[task 2018-04-12T07:05:35.204Z] 07:05:35     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:312:5
[task 2018-04-12T07:05:35.204Z] 07:05:35     INFO -      check_not_accepted@layout/style/test/test_property_syntax_errors.html:36:7
[task 2018-04-12T07:05:35.205Z] 07:05:35     INFO -      run@layout/style/test/test_property_syntax_errors.html:101:7
[task 2018-04-12T07:05:35.205Z] 07:05:35     INFO -      onload@layout/style/test/test_property_syntax_errors.html:1:1
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/eaf30a1f59ee
Let overflow parse two values. r=xidorn
Flags: needinfo?(emilio)
https://hg.mozilla.org/mozilla-central/rev/eaf30a1f59ee
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10455 for changes under testing/web-platform/tests
The compat data is updated for this: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#Browser_compatibility

Marking as dev-doc-complete, but please comment if you think we need any other docs here.
Keywords: dev-doc-needed → dev-doc-complete
(In reply to Will Bamberg [:wbamberg] from comment #14)
> The compat data is updated for this:
> https://developer.mozilla.org/en-US/docs/Web/CSS/
> overflow#Browser_compatibility
> 
> Marking as dev-doc-complete, but please comment if you think we need any
> other docs here.

rel note added: https://developer.mozilla.org/en-US/Firefox/Releases/61#CSS
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: