Nils Ohlmeier [:drno] Reporter
	Description • 6 years ago

After bug 1451926 has landed we should discuss what is required and under which circumstances we turn the user pref for AV1 back to on.

	Nils Ohlmeier [:drno] Reporter
	Comment 1 • 6 years ago

Dan, what does it take from your point of view before we can pref AV1 on again?

	Chris Mills [:cmills]
	Comment 2 • 6 years ago

We ought to go through MDN to see if we cover AV1 support in appropriate places. Adding a ddn as a reminder here.

	Daniel Veditz [:dveditz]
	Comment 3 • 6 years ago

(In reply to Nils Ohlmeier [:drno] from comment #1)
> Dan, what does it take from your point of view before we can pref AV1 on again?

There should be few enough security vulnerabilities that we can file and track them individually in Bugzilla.

It should stand up to fuzzing for a reasonable period of time and with the only potentially exploitable signatures it spits out ones that are already known and on file. (I'll let abillings and the fuzzing team define "reasonable period")

Otherwise we'll get bled dry by bounty folks racing with our own team. I'm surprised that hasn't happened yet but I guess the fact that it was there has flown under the radar.

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 6 years ago

The Nightly 65 soft freeze starts on Monday - what's the status here?

	Nils Ohlmeier [:drno] Reporter
	Comment 6 • 6 years ago

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> The Nightly 65 soft freeze starts on Monday - what's the status here?

So over in bug 1498624 we are landing sandboxing code for the RDD process right now. Once that is in I believe we can turn on the RDD process on Win and Mac. And then we can turn AV1 on on these two platforms.

So yes I would like to still turn it on in 65.

	Pulsebot
	Comment 8 • 6 years ago

Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e6cbbc4c53e
flip av1 and rdd on for OSX and Win. r=drno

	Andreea Pavel [:apavel]
	Comment 9 • 6 years ago

Backed out for leaks on OS X and chrome failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e6cbbc4c53e3c0cc762b8c716d5e6370a11bd17

Failure logs:

Chrome: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214751779&repo=autoland&lineNumber=2302

BC: https://treeherder.mozilla.org/logviewer.html#?job_id=214746707&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/c4a45f2bd13972fb4728aefab69197c6d2eb2215

	Nils Ohlmeier [:drno] Reporter
	Comment 10 • 6 years ago

(In reply to Andreea Pavel [:apavel] from comment #9)
> BC:
> https://treeherder.mozilla.org/logviewer.html#?job_id=214746707&repo=autoland

I guess this one is easily fixed by adding 'rdd' to the list here https://searchfox.org/mozilla-central/source/testing/mozbase/mozleak/mozleak/leaklog.py#174

	Andreea Pavel [:apavel]
	Comment 11 • 6 years ago

Nils there were other failures:

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=88f8e61c7b04acfb705448f02851b0c17ca470db&group_state=expanded&tochange=2f0e92d76c4e96fe66f0aab96075c22b3692f116&failure_classification_id=2&searchStr=M-e10s&selectedJob=214753509

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=88f8e61c7b04acfb705448f02851b0c17ca470db&group_state=expanded&tochange=2f0e92d76c4e96fe66f0aab96075c22b3692f116&failure_classification_id=2&searchStr=M-e10s&selectedJob=214753437

These all appeared to be from your patch.

	Nils Ohlmeier [:drno] Reporter
	Comment 12 • 6 years ago

Try run with leaklog.py patched https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd72ad38a2dc8183f16526153d8ebef432288d33

	Nils Ohlmeier [:drno] Reporter
	Comment 13 • 6 years ago

mjf: what I find strange is why do these memory and process checks all encounter the RDD process? Isn't the RDD process suppose to be started only if we need it for decoding AV1 videos (and I doubt these test pages attempt that)?

	Michael Froman [:mjf] Assignee
	Comment 14 • 6 years ago

(In reply to Nils Ohlmeier [:drno] from comment #13)
> mjf: what I find strange is why do these memory and process checks all
> encounter the RDD process? Isn't the RDD process suppose to be started only
> if we need it for decoding AV1 videos (and I doubt these test pages attempt
> that)?
No, RDD process is started at launch (just like the GPU process is on Windows-only).

	Nils Ohlmeier [:drno] Reporter
	Comment 15 • 6 years ago

Added RDD to about memory checks - try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b638ef4ec0fc449dd5006880bfa835b260ae8dc

	Michael Froman [:mjf] Assignee
	Comment 16 • 6 years ago

About mem checks, leak check rdd process awareness, and add a 400 byte leak check threshold for rdd.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6291a80a56cf90d08d68ab3da2a4d0649f63699d

	Nils Ohlmeier [:drno] Reporter
	Comment 17 • 6 years ago

Another try run with PID removed from process name https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfc5ce706a31c5923c4d451124bbaa80ee45a356

	Nils Ohlmeier [:drno] Reporter
	Comment 18 • 6 years ago

Updated RDD about memory numbers https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dd16391688dce89948e56e0ef4da5f85a621347

	Pulsebot
	Comment 20 • 6 years ago

Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3c8a3a052ea
flip av1 and rdd on for OSX and Win. r=mjf

	Noemi Erli[:noemi_erli]
	Comment 21 • 6 years ago

Backed out changeset b3c8a3a052ea (Bug 1452146) for mochitest automation.py failures

Push with failureS: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=215231290&revision=b3c8a3a052ea96b093839b5732661e6c1d006a77

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215231290&repo=autoland&lineNumber=31716

Backout: https://hg.mozilla.org/integration/autoland/rev/b1c9fa45f90ee5f26843749557a2fda84581f406

	Michael Froman [:mjf] Assignee
	Comment 22 • 6 years ago

Pref on only for Win try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb27b71aed28fd8d8e039e9522e64f1b018748f6

	Ryan VanderMeulen [:RyanVM]
	Comment 23 • 6 years ago

(In reply to Michael Froman [:mjf] from comment #22)
> Pref on only for Win try run:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=bb27b71aed28fd8d8e039e9522e64f1b018748f6

Looks like this still has a bunch of Windows leaks? This seems pretty unlikely to make it into the first beta of 65 at this point.

	Michael Froman [:mjf] Assignee
	Comment 24 • 6 years ago

We're not going to make 65 - we're dealing with Sandbox issues.

	Pulsebot
	Comment 25 • 5 years ago

Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ded3b65ca045
flip av1 and rdd on for Win. r=drno

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 26 • 5 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ded3b65ca045

	Nils Ohlmeier [:drno] Reporter
	Comment 27 • 5 years ago

Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Firefox users won't be able to watch video content encoded in the new AV1 codec.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1513101

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch itself only flips the pref for AV1. There is only limited amount of content available in AV1 yet (but we expect more to show up soon), thus the impact for most of the Firefox users should be minimal.

String changes made/needed: N/A

	Ryan VanderMeulen [:RyanVM]
	Comment 28 • 5 years ago

For the sake of simpler tracking, can we please repurpose this bug to just the Windows case and move unconditional enabling to a new bug?

	Michael Froman [:mjf] Assignee
	Comment 29 • 5 years ago

(In reply to Ryan VanderMeulen [:RyanVM] from comment #28)
> For the sake of simpler tracking, can we please repurpose this bug to just
> the Windows case and move unconditional enabling to a new bug?
Sure - I'll change the title.

	Ryan VanderMeulen [:RyanVM]
	Comment 30 • 5 years ago

Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!

[Triage Comment]
Approved for 65.0b5, thanks.

	Cosmin Sabou [:CosminS]
	Comment 31 • 5 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/d9d17041ca84