Closed
Bug 1451823
Opened 7 years ago
Closed 7 years ago
Support ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG <a> elements
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
7.52 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → longsonr
Assignee | ||
Updated•7 years ago
|
Attachment #8965403 -
Attachment is patch: true
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8965403 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8965458 [details] [diff] [review]
implement and fix test
Passes the tests in bug 1450824 except for 1 expected failure and 1 test bug (https://github.com/w3c/web-platform-tests/pull/10275)
The attributes are DOMString based on the resolution in https://github.com/w3c/svgwg/issues/315 and the tests from https://github.com/w3c/web-platform-tests/pull/10275 expect that too.
Checkin comment:
Bug 1451823 - support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements r=mystor
Attachment #8965458 -
Flags: review?(nika)
Updated•7 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment on attachment 8965458 [details] [diff] [review]
implement and fix test
Review of attachment 8965458 [details] [diff] [review]:
-----------------------------------------------------------------
Please make sure you send a Request to Implement & Ship to dev-platform before landing this :-)
::: dom/svg/SVGAElement.cpp
@@ +34,5 @@
> { &nsGkAtoms::target, kNameSpaceID_None, true }
> };
>
> +// static
> +const DOMTokenListSupportedToken SVGAElement::sSupportedRelValues[] = {
It'd be nice to merge this with the HTMLAnchorElement::sSupportedRelValues, but that may not be worth doing in this patch.
Attachment #8965458 -
Flags: review?(nika) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1d4a3e6c77a
support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements r=mystor
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10473 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 12•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Upstream PR merged
Comment 14•7 years ago
|
||
Mentioned on Firefox 61 for developers:
https://developer.mozilla.org/en-US/Firefox/Releases/61
Updated reference pages:
https://developer.mozilla.org/en-US/docs/Web/API/SVGAElement
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/a
Updated support info page:
https://developer.mozilla.org/en-US/docs/Web/SVG/SVG_2_support_in_Mozilla#Linking
Compat data (currently in review, will update compat tables on MDN reference pages once this is merged):
https://github.com/mdn/browser-compat-data/pull/2018
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•