Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Description • 6 years ago

As noted in the code we should remove all the deprecated commands for Firefox 60, so we don't have to carry those along with the ESR release:

https://dxr.mozilla.org/mozilla-central/rev/c23c7481957f7b982cffc0ce1d25979c69ca2c2f/testing/marionette/driver.js#3587-3653

A little bit more work seems to be necessary for setWindowPosition and setWindowSize (bug 1348145) which a contributor starts working on now. I would leave that as a separate bug.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 1 • 6 years ago

Doh! We cannot get them all removed because Marionette client doesn't support the new commands yet. So the client has to be updated and released first. Given the still a bit unclear status of the update tests, we need further releases before we can remove all old commands from driver.js. :(

I will file a new client bug, to get all the commands updated.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 2 • 6 years ago

With bug 451727 fixed and uplifted soon for Firefox 60, the removal of the old commands has to wait until Firefox 63.

	Henrik Skupin [:whimboo][⌚️UTC+1] Reporter
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8995762 [details]
Bug 1451725 - Remove deprecated WebDriver Commands

https://reviewboard.mozilla.org/r/260128/#review267754

Thank you! The try build also passes, so that I will try to get it landed now.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea17a96c5eb0
Remove deprecated WebDriver Commands r=whimboo

	Daniel Varga [:dvarga]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ea17a96c5eb0