Pete Moore [:pmoore][:pete] Reporter
	Description • 6 years ago

Currently we use github.com/taskcluster/runlib under the hood to manage executing processes on Windows using CreateProcessAsUser syscall.

From go 1.10 onwards, it is now possible to do this via the go standard library.

This can be done by setting (syscall.SysProcAttr).Token inside (os/exec.Cmd).SysProcAttr.

At the same time it may make sense to start using https://golang.org/pkg/os/exec/#CommandContext and then cancel the context in order to terminate the command.

	Pete Moore [:pmoore][:pete] Reporter
	Comment 1 • 6 years ago

(In reply to Pete Moore [:pmoore][:pete] from comment #0)

> At the same time it may make sense to start using
> https://golang.org/pkg/os/exec/#CommandContext and then cancel the context
> in order to terminate the command.

(when aborting a task)

	[github robot]
	Comment 2 • 6 years ago

Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/b277fa8a9409cd44206b90801646972ff35357bc
Bug 1447265 - use os/exec package on Windows too

https://github.com/taskcluster/generic-worker/commit/9529f9818ff1c7ace1fb427fe1fb2270d0f5fe5e
Merge pull request #80 from taskcluster/bug1447265

Bug 1447265 - use os/exec package on Windows too

	Pete Moore [:pmoore][:pete] Reporter
	Comment 3 • 6 years ago

Released in generic-worker 10.7.7.