Closed
Bug 1447045
Opened 6 years ago
Closed 6 years ago
Maximisation delta of 8 px not enough on certain Linux configs
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
test_window_maximize.py [1] uses a delta of 8 px on non-Windows platforms when checking whether the window was maximised: (max width - delta) = acceptable max width This is done so that window manager specific limitations do not affect the outcome of the tests. On my current Linux setup where I X11 forward the Firefox window to macOS a delta of 8 px is not enough. The minimum requirement is 22px. [1] https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py#37
Assignee | ||
Updated•6 years ago
|
Blocks: marionette-window-tracking
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8960224 [details] Bug 1447045 - Increase maximize delta to 22 px. https://reviewboard.mozilla.org/r/228984/#review235090
Attachment #8960224 -
Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ac3210cae51 Increase maximize delta to 22 px. r=maja_zf
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ac3210cae51
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•