Andreas Tolfsen ❲:ato❳ Reporter
	Description • 6 years ago

After central gained support for cargo workspaces, the $(topsrcdir)/target
directory is not removed when cleaning:

> % ./mach build testing/geckodriver
> % ./mach clobber
> % file target
> target: directory

	Nathan Froyd [:froydnj]
	Comment 1 • 6 years ago

This appears to be because `mach clobber` only clobbers the objdir, and now with workspaces, we have object files built outside of the objdir.

mbrubeck, can you fix things up so Cargo is building everything inside the objdir, or if we should have been doing that already, look into why that's not happening?

	Matt Brubeck (:mbrubeck) Assignee
	Comment 2 • 6 years ago

I can't reproduce this:

> $ ./mach build >/dev/null
> $ ./mach build testing/geckodriver/
>  0:00.16 /usr/bin/make -C /home/mbrubeck/src/mozilla-central/obj-stylo-debug -j8 -s backend
>  0:00.23 /usr/bin/make -j8 -s testing
>  0:00.30 /usr/bin/make -j8 -s testing/geckodriver
>  0:00.39 Your build was successful!
> $ file target
> target: cannot open `target' (No such file or directory)

`mach build` sets `$CARGO_TARGET_DIR` to point into the objdir, so it won't put anything in `$topsrcdir`.

However, running `cargo` directly (not through `mach build`) without setting this environment variable will place the `target` directory outside the objdir.  This was also true before bug 1381576, but the location of the `target` directory has changed.  It is now at the root of the workspace, rather than the root of the package being built.

As before, if you build with `cargo build` then you can clobber with `cargo clean`.