Closed
Bug 1444987
Opened 6 years ago
Closed 5 years ago
Targeted unread count badge border radius does not apply
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird65 fixed, thunderbird66 fixed)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: freaktechnik, Assigned: Paenglab)
References
Details
Attachments
(3 files)
758 bytes,
image/png
|
Details | |
3.65 KB,
patch
|
clokep
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
33.13 KB,
image/png
|
Details |
The badge on the chat button that shows the count of unread mentions/targeted messages does not get its borders rounded properly when a value is set. A possible fix is to wrap the label in a box and style the box instead.
Reporter | ||
Updated•6 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
Comment 1•5 years ago
|
||
I think I'm seeing the same behavior on current beta, but I'm not 100% sure how it is SUPPOSED to look.
Maybe Richard has an idea if there is anything actionable here?
Flags: needinfo?(richard.marti)
Assignee | ||
Comment 2•5 years ago
|
||
It seems on the label itself border-radius works no more. Wrapping the label inside a box and apply the styles to the box fixes this.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9036516 -
Flags: review?(clokep)
Comment 3•5 years ago
|
||
Comparison of with and without the patch.
Comment 4•5 years ago
|
||
Comment on attachment 9036516 [details] [diff] [review] 1444987-badge-radius.patch Review of attachment 9036516 [details] [diff] [review]: ----------------------------------------------------------------- So I wasn't really sure whether to approve this or not -- I think we could do a much better job with this icon. I'm giving it an r+ because it fixes the actual issue and I think we should uplift this to beta sooner rather than later.
Attachment #9036516 -
Flags: review?(clokep) → review+
Comment 5•5 years ago
|
||
Comment on attachment 9036516 [details] [diff] [review] 1444987-badge-radius.patch [Approval Request Comment] Regression caused by (bug #): See attachment 9037416 [details] User impact if declined: Broken styling on icon Testing completed (on c-c, etc.): None Risk to taking this patch (and alternatives if risky): Small risk, if anything the styling will just be broken in a different way
Attachment #9036516 -
Flags: approval-comm-beta?
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/151bb059674b
Make the border-radius on the badges working again. r=clokep
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 66.0
Updated•5 years ago
|
Attachment #9036516 -
Flags: approval-comm-beta? → approval-comm-beta+
Comment 7•5 years ago
|
||
We should probably wait on uplifting this since we suspect it is causing bug 1521481.
Comment 8•5 years ago
|
||
TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/48b416ee9271b60a781429b96e671fe4e4ea93e0
status-thunderbird65:
--- → fixed
status-thunderbird66:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•