Closed Bug 1444118 Opened 6 years ago Closed 6 years ago

Better log message if chain of trust key is not valid

Categories

(Taskcluster :: Workers, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Unassigned)

References

Details

We had an incident where the following configuration generic-worker.config setting was set in production:

> "signingKeyLocation": "not-configured"

The generic-worker refused to start up, and reported

> open not-configured: The system cannot find the file specified.

This message was confusing, until you realised that "not-configured" was the fake filename used in the config file.

We could probably improve this error message to explain that the file 'not-configured' is specified as property "signingKeyLocation" in config file XYZ (where XYZ is replaced with the config file that was loaded).

This is a nice-to-have, not a critical feature.
Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/580eedc131313867783cb67260eb493bd47481ea
Bug 1444118 - better error messages if CoT key can't be loaded

https://github.com/taskcluster/generic-worker/commit/76200d409ab46f2a8219199ff6a9bfa81be37e62
Merge pull request #77 from taskcluster/bug1444118

Bug 1444118 - Improve logging when chain of trust initialisation checks fail
Depends on: 1461901
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Generic-Worker → Workers
You need to log in before you can comment on or make changes to this bug.