toy.raymond Reporter
	Description • 6 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.106 Safari/537.36

Steps to reproduce:

Run this:

c = new AudioContext();
b = new AudioBuffer({length: 1, numberOfChannels: 3, sampleRate: c.sampleRate});
n = new ConvolverNode(c)
n.buffer = b


Actual results:

A SyntaxError is thrown when setting the buffer to b.


Expected results:

A NotSupportedError must be thrown: https://webaudio.github.io/web-audio-api/#dom-convolvernode-buffer

	ovidiu boca[:Ovidiu]
	Comment 1 • 6 years ago

Hi toy.raymond,

Did you run this script in Browser Console?

	Alex Chronopoulos [:achronop]
	Comment 2 • 6 years ago

Copy from the spec:
"The AudioBuffer MUST have 1, 2, or 4 channels or a NotSupportedError exception MUST be thrown."

	ovidiu boca[:Ovidiu]
	Comment 4 • 6 years ago

This is reproducible also on Mac OS X 10.12 with FF 58 and FF Nightly 60.0a1(2018-03-07).

	Karl Tomlinson (:karlt)
	Comment 5 • 6 years ago
mozreview-review

Comment on attachment 8957114 [details]
Bug 1443228 - Make the ConvolverNode ctor throw NotSupportedError when passed a buffer with an invalid channel count.

https://reviewboard.mozilla.org/r/226054/#review232168

	Pulsebot
	Comment 6 • 6 years ago

Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/0a5ec71513a7
Make the ConvolverNode ctor throw NotSupportedError when passed a buffer with an invalid channel count. r=karlt

	Noemi Erli[:noemi_erli]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/0a5ec71513a7

	Chris Mills [:cmills]
	Comment 8 • 6 years ago

I've added details about the NotSupportedError to the constructor ref page:

https://developer.mozilla.org/en-US/docs/Web/API/ConvolverNode/ConvolverNode#Exceptions

I've also added a note to the Fx60 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/60#Media_and_WebRTC

Let me know if this looks OK. Thanks!

	Paul Adenot (:padenot) Assignee
	Comment 9 • 6 years ago

Perfect as usual, Chris, thanks!