Closed Bug 1442610 Opened 6 years ago Closed 6 years ago

Some of the deleted bookmarks from Device 1 are displayed on Device 2 after crashing Firefox during sync

Categories

(Firefox :: Sync, defect)

60 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1447832
Tracking Status
firefox60 --- affected

People

(Reporter: cbadau, Unassigned)

Details

Attachments

(1 file)

[Affected versions]:
- Nightly 60.0a1 (3/2/2018)

[Affected platforms]:
- Windows 7 x64
- Ubuntu 14.04 x64 
- macOS 10.13 

[Steps to reproduce]:
1. On device 1, sign in to Sync with a Firefox Account and wait for the first sync to finish.
2. On device 2, sign in to Sync with the same account and wait for the first sync to finish.
3. On device 1, delete some bookmarks from one folder or delete several folders. Trigger a sync ("Tools -> Sync now") and wait for the sync to finish.
4. On device 2, trigger a sync and while the sync is in progress, crash Firefox.
5. On device 2, restart Firefox with the same profile and wait for sync to start.
6. On device 2, verify that the deleted bookmarks from step 3 aren't displayed anymore.

[Expected result]:
- The deleted bookmarks from step 3 aren't displayed anymore on device 2.

[Actual result]:
- Some of the deleted bookmarks are displayed on device 2. 

[Regression range]:
- I think this is not a regression because (maybe) it's a server related issue. 

[Additional notes]:
- The issue is reproducible also if you close/quit the Firefox, not only when you crash Firefox (see step 4). 
- This is an intermittent issue.
- I crash Firefox using this snippet: 
> Cu.import("resource://gre/modules/ctypes.jsm");
> let zero = new ctypes.intptr_t(8);
> let badptr = ctypes.cast(zero, ctypes.PointerType(ctypes.int32_t));
> badptr.contents;
Flags: needinfo?(markh)
Thanks for the report, but I'm not sure this is actionable as it stands - we probably need "Trace" logs from both of the devices, and some idea of what the bookmark titles etc were when this happened. Could you please arrange for these Trace logs (https://addons.mozilla.org/en-US/firefox/addon/about-sync/ might help here), then reproduce the issue, and upload the logs from both profiles?
Flags: needinfo?(markh) → needinfo?(camelia.badau)
Attached file deletedbookmarks.zip
Scenario: 
- sign in to Sync with the same Firefox Account on Device 1 and Device 2

- install the About Sync add-on on those two devices and then open about:sync page

- on Device 1, delete some folders and then trigger a sync (Tools->"Sync Now") -> at this moment, export the logs: please see "device1" file 

- on Device 2, trigger a sync and while the sync is in progress, Exit Firefox -> reopen Firefox with the same profile and wait for sync to start => some/all of the deleted bookmarks from Device 1 are displayed on Device 2 - please see exported logs "device2"

- on Device 1, I click on the refresh button from the about:sync page and I obtain the following logs: see "device1-after refresh" file
Flags: needinfo?(camelia.badau)
Flags: needinfo?(markh)
This is almost certainly a dupe of bug 1447832 - deleting bookmarks while syncing can cause another device to resurrect them. That should be landing soon, so it would be great to see if you can reproduce it once that other bug lands.

Thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(markh) → needinfo?(camelia.badau)
Resolution: --- → DUPLICATE
I don't see the issue anymore on Windows and macOS using Firefox 65 Beta 5. 
Removing needinfo.
Flags: needinfo?(camelia.badau)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: