Closed
Bug 1441228
Opened 6 years ago
Closed 6 years ago
WebDriver:TakeScreenshot should return invalid argument error on malformed input
Categories
(Remote Protocol :: Marionette, enhancement, P3)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8954084 [details] Bug 1441228 - Correct error returned for invalid input to capture.highlight_. https://reviewboard.mozilla.org/r/223244/#review229302 ::: testing/marionette/capture.js:7 (Diff revision 1) > * License, v. 2.0. If a copy of the MPL was not distributed with this file, > * You can obtain one at http://mozilla.org/MPL/2.0/. */ > > "use strict"; > > +const {InvalidArgumentError} = ChromeUtils.import("chrome://marionette/content/error.js", {}); This should cause a linter failure because it extends 78 chars.
Attachment #8954084 -
Flags: review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8954084 [details] Bug 1441228 - Correct error returned for invalid input to capture.highlight_. https://reviewboard.mozilla.org/r/223244/#review229302 > This should cause a linter failure because it extends 78 chars. It doesn’t and I think perhaps the reason is that long strings are exempted.
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b634845f959c Correct error returned for invalid input to capture.highlight_. r=whimboo
Assignee | ||
Updated•6 years ago
|
Attachment #8954084 -
Flags: review?(mjzffr)
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b634845f959c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•