Anca Soncutean, Desktop QA Reporter
	Description • 6 years ago

[Affected versions]: 
- 60.0a1 (2018-02-22)

[Affected platforms]:
- Ubuntu 16.04 ( x86 and x64)
- Ubuntu 14.04 x64
- Windows 10 x64

[Steps to reproduce]:
1. Launch Firefox
2. Go to any site that does not support Reader view mode  (eg. youtube)
3. From Menu bar - Customize, select Dark theme
4. Print Preview the page
5. Observe the Simplify Page checkbox 

[Expected result]:
- Both the Simplify Page label and the checkbox are grey out. 

[Actual result]:
- Only the Simplify Page is grey out (this can create confusion for some users)- https://goo.gl/rX2J9T

[Regression range]:
Not a regression, I was able to reproduce this issue on old Nightly from 2016-07-12 as well (where the feature was first introduced).

[Additional notes]:
- Note that in the default and light theme, both the labels’ button and the checkboxes are grey out  when Reader View is disabled

	Mike Conley (:mconley) (:⚙️)
	Comment 1 • 6 years ago

Hey Connor, now that you're wrapping up your sidebar work, any chance you'd have the time to look at this small bug?

	Connor Masini
	Comment 2 • 6 years ago

(In reply to Mike Conley (:mconley) (:⚙️) (Totally backlogged on reviews and needinfos) from comment #1)
> Hey Connor, now that you're wrapping up your sidebar work, any chance you'd
> have the time to look at this small bug?

I'm still working on Bug 1441708 as well at the moment. Let me see if I can finish both of my current bugs up first and I'll let you know then. I'm anticipating finishing the bugs Wednesday or Thursday evening.

	Daniel Holbert [:dholbert]
	Comment 3 • 6 years ago

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #0)
> [Expected result]:
> - Both the Simplify Page label and the checkbox are grey out. 

Possible-alternate-Expected-Result: Maybe we should just hide the checkbox and the label entirely, for sites that don't support reader mode.

Just discussed this with mconley in IRC. My arguments:
 (1) The majority of my open tabs do not support reader mode. So most of the time (for my usage at least) this piece of UI is disabled.
 (2) This UI is decently large, given its label -- it's ~10% of the width of my default-sized Firefox window.
 (3) It's confusing to present the user with large primary UI elements that are unavailable most of the time. (Consider e.g. if we had some buttons on the default toolbar that were grayed out most of the time and were only enabled for a fraction of somewhat-arbitrary URLs)
 (4) The hover tooltip is meant to be helpful, but it's not really -- it just says "This page cannot be automatically simplified", which sounds like the page is too complex, and for basic pages like about:blank or data:text/plain,abc (which show this UI disabled), this message is quite confusing.

This alternate Expected Result would be a slightly bigger change here, and would require UX signoff, but I think it's worth considering since it'd mean we wouldn't really want to iterate on this design if we're just going to remove it.