Closed Bug 1439517 Opened 6 years ago Closed 6 years ago

generic-worker: support taskcluster-proxy

Categories

(Taskcluster :: Workers, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Assigned: pmoore)

References

Details

Attachments

(1 file)

This will reduce the need for many workarounds that are currently in place.
QA Contact: pmoore
I've started work on this - not complete yet. Work will go in this PR, and I'll add a comment here when it is ready for review.
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Just about ready now. There is a unit test which is passing, but I'll add an integration test tomorrow.
Ah - and I'll need to handle credential updates during task execution - so still a bit of work to do. Credentials can get updated while the task is running, which we'll need to handle. There is a taskcluster-proxy endpoint for handling this, so it shouldn't be too tricky.
This is done now - although I don't have a test which explicitly checks that the credentials PUT updates work - just because that would involve a bunch of mocking or customising the reclaim timings so a test could reclaim more quickly than waiting 20 mins.

Oh, I guess I should do that, just to be safe... I'll do that shortly.

Aside from testing the credentials PUT update to /credentials works against taskcluster-proxy, the rest is implemented and has tests.
OK, I think I'm done - just waiting for tests to run.
I'll fix the tests on Monday morning - nothing serious, just some roles need to be updated, and some PATH settings...
Oh, and a data race... Shouldn't be too much work to fix.
Depends on: 1399401
Attachment #8953103 - Flags: review?(jhford)
The issues are resolved now, and the tests are all passing.
Deployed in bug 1399401.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8953103 - Flags: review?(jhford) → review+
Component: Generic-Worker → Workers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: