Cameron McCormack (:heycam) Assignee
	Description • 6 years ago

The synthesizeText function in event.js doesn't seem to be used, and it currently tries to call the non-existent nsIDOMWindowUtils.sendTextEvent function, which was removed/reworked in bug 911951.  I guess we can just remove it?

(It would be nice if we had less duplication between testing/marionette/event.js and testing/mochitest/tests/SimpleTest/EventUtils.js.)

	Cameron McCormack (:heycam) Assignee
	Comment 2 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e094823f0f13481f07eb14c9ba7033ef2842122

	Cameron McCormack (:heycam) Assignee
	Comment 3 • 6 years ago

synthesizeCompositionEvent is in the same boat -- it calls nsIDOMWindowUtils.sendCompositionEvent which no longer exists.  I'm less certain this is unused but probably it is.

	Cameron McCormack (:heycam) Assignee
	Comment 5 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef18cf5399a8250521e75518d5fb75871491cb4a

	Andreas Tolfsen ❲:ato❳
	Comment 6 • 6 years ago
mozreview-review

Comment on attachment 8952048 [details]
Bug 1439288 - Remove unused synthesizeText function.

https://reviewboard.mozilla.org/r/221272/#review227150

> I guess we can just remove it?

Yes (-:

	Andreas Tolfsen ❲:ato❳
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8952050 [details]
Bug 1439288 - Remove synthesizeCompositionEvent.

https://reviewboard.mozilla.org/r/221274/#review227152

	Pulsebot
	Comment 8 • 6 years ago

Pushed by cam@mcc.id.au:
https://hg.mozilla.org/integration/autoland/rev/d0406024a77b
Remove unused synthesizeText function. r=ato
https://hg.mozilla.org/integration/autoland/rev/1274d9304cec
Remove synthesizeCompositionEvent. r=ato

	Natalia Csoregi [:nataliaCs]
	Comment 9 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d0406024a77b
https://hg.mozilla.org/mozilla-central/rev/1274d9304cec