Closed
Bug 1438919
Opened 6 years ago
Closed 6 years ago
[Linux] Some Top Sites context menu option labels have wrong glyph spacing
Categories
(Core :: Graphics: Text, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | verified |
firefox60 | --- | verified |
People
(Reporter: JuliaC, Assigned: jfkthame)
References
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(1 file)
233.51 KB,
image/png
|
Details |
[Affected versions]: - 60.0a1 (2018-02-15) - 59.0b10 build3 (20180215111455) [Affected platforms]: - Ubuntu 16.04 x64 [Steps to reproduce]: 1. Launch Firefox. 2. Open a new tab. 3. Hover a random top site and access its context menu 4. Inspect the "Open in a New Window" and "Open in a New Private Window" context menu options [Expected result]: - Each context menu option is properly displayed and fully functional [Actual result]: - There is a missing space between the "New" and "Window" words from the "Open in a New Window" option - There is a missing space between the "New" and "Private" words from the "Open in a New Private Window" option [Regression range]: - This seems to be a recent regression: * Last good revision: b19b1b50594e7e9d075e9dcb27bc88fe25850c95 * First bad revision: 1e5e317d90ecf586136e626bb3f2552f198ef0bc * Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b19b1b50594e7e9d075e9dcb27bc88fe25850c95&tochange=1e5e317d90ecf586136e626bb3f2552f198ef0bc [Additional notes]: - It seems that Arch Linux is not affected
Comment 1•6 years ago
|
||
Is this regression from either/both bugs? Bug 1431866 - Avoid risk of undefined behavior in gfxFontStyle::Hash() calculation. r=jrmuizel Bug 1430446 - Prefer hinted glyph widths from FreeType, except when hinting is disabled or the font includes variations. r=lsalzman
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 2•6 years ago
|
||
It'll be related to bug 1430446, though I don't currently understand the exact circumstances where it goes wrong. (E.g. it looks fine on my Ubuntu machine here.) Lee, does this reproduce for you?
Blocks: 1430446
Component: Activity Streams: Newtab → Graphics: Text
Flags: needinfo?(jfkthame) → needinfo?(lsalzman)
Product: Firefox → Core
Summary: Some Top Sites context menu option labels have wrong spacing → [Linux] Some Top Sites context menu option labels have wrong glyph spacing
Comment 3•6 years ago
|
||
The screenshot I made for attachment 8951684 [details] was from the firefox-dev vm: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Using_the_VM Top is 58.0.2 and bottom was a recent m-c 60 build.
Updated•6 years ago
|
Whiteboard: [gfx-noted]
Comment 4•6 years ago
|
||
We can still take a patch for 60 or even 59 but I don't think this needs to block the 59 release.
Updated•6 years ago
|
Priority: -- → P3
Comment 5•6 years ago
|
||
Given the we fixed the suspected regression from bug 1430446 in bug 1440938, is this fixed for you now?
Flags: needinfo?(lsalzman) → needinfo?(iulia.cristescu)
Reporter | ||
Comment 6•6 years ago
|
||
(In reply to Lee Salzman [:lsalzman] from comment #5) > Given the we fixed the suspected regression from bug 1430446 in bug 1440938, > is this fixed for you now? I can confirm that the initial issue is now fixed on 60.0b3 build1 (20180312152746) and 59.0 build5 (20180310025718), using Ubuntu 16.04 x64.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(iulia.cristescu)
Resolution: --- → FIXED
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•