Closed
Bug 1438001
Opened 6 years ago
Closed 5 years ago
Replace use of flatpickr date picker with native date inputs
Categories
(Socorro :: General, task, P2)
Socorro
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wsmwk, Assigned: willkg)
References
Details
Attachments
(2 files)
Using time shortcuts for From and To, I cannot query to the most recent minutes. It shows "to 5 hours ago."which is equivalent to my timezone offset. - https://crash-stats.mozilla.com/topcrashers/?product=Thunderbird&version=59.0b1 - click first crash signature - it gives results to very recent minutes (say 5-35 minutes) - click show filters - click a time shortcut, like 14 days. - click search results: if time was 15:21 (which is correct local time), the search results show time of 10:21 (a differents of 5 hours) equal to my timezone. If it is really searching to 10:21 EST then no results shown for the last 5 hours. Certain other sequences of arriving at a query and clicking a shortcut do NOT exhibit this problem.
Reporter | ||
Comment 1•6 years ago
|
||
The search URL with the incorrect results shows <2018-02-13T15%3A46%3A00.000Z Note 15:46 is my LOCAL time, not zulu
Reporter | ||
Comment 2•6 years ago
|
||
[1] I can't reduce to less than "to 5 hours ago." even by editing the url. it has 31 crashes for nsStringBuffer::Release [2] Which has no signature specified, and is to the most recent minutes, shows 37 crashes for nsStringBuffer::Release [1] https://crash-stats.mozilla.com/signature/?product=Thunderbird&version=59.0b1&signature=nsStringBuffer%3A%3ARelease&date=%3E%3D2018-02-10T11%3A47%3A52.000Z&date=%3C2018-02-13T11%3A47%3A52.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports [2] https://crash-stats.mozilla.com/search/?product=Thunderbird&version=59.0b1&date=%3E%3D2018-02-06T16%3A45%3A05.000Z&date=%3C2018-02-13T16%3A45%3A05.000Z&_sort=-date&_facets=signature&_facets=email&_columns=date&_columns=signature&_columns=platform&_columns=email&_columns=user_comments&_columns=uptime#facet-signature
Reporter | ||
Comment 3•6 years ago
|
||
Adrian do you know whether this is a permanent limitation?
Flags: needinfo?(adrian)
Summary: super search time "shortcut" adjusts by timezone → super search time "shortcut" From and To are incorrectly adjusted by timezone, cutting off most recent results
Assignee | ||
Comment 4•6 years ago
|
||
I think it's an issue with the ui. I don't think the API has this problem. If it helps, I usually put the "To" a day in the future.
Flags: needinfo?(adrian)
Assignee | ||
Updated•6 years ago
|
Whiteboard: [good first bug]
Updated•6 years ago
|
Assignee: nobody → is2ei.horie
Comment 5•6 years ago
|
||
Hi Will, I attached PR link. Could you please review it?
Attachment #8979085 -
Flags: review?(willkg)
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8979085 [details] [review] GitHub pull request Removing me as reviewer. We track code review and status in GitHub and Mike is reviewing this there already.
Attachment #8979085 -
Flags: review?(willkg)
Comment 7•6 years ago
|
||
I closed the PR since Flatpickr does not support UTC now.
Comment 8•6 years ago
|
||
Re-scoping this bug to be about replacing Flatpickr, since it doesn't support UTC in a way that works with our requirements, mainly: - All displayed dates should be in UTC. - All dates sent to the server should be in UTC - Clicking the shortcut links should fill the date pickers with UTC times - The "Showing results from 3 minutes ago to now" text should be relative to the user's local time, even if the dates we're working with are UTC (otherwise, it says things like "7 hours ago" instead of "now" due to timezone offsets). There's good browser support for date and time pickers now, so we should be using those instead.
Assignee: is2ei.horie → nobody
Summary: super search time "shortcut" From and To are incorrectly adjusted by timezone, cutting off most recent results → Replace use of flatpickr date picker with native date inputs
Whiteboard: [good first bug]
Updated•6 years ago
|
Priority: -- → P3
Comment 10•6 years ago
|
||
is2ei: Thank you for the offer, but we haven't yet decided the design we want to use with the new date and time pickers, which is why I removed the "good first bug" label. I'd like to wait until we have something like that before we start work on this again.
Flags: needinfo?(mkelly)
Comment 11•6 years ago
|
||
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #10) > is2ei: Thank you for the offer, but we haven't yet decided the design we > want to use with the new date and time pickers, which is why I removed the > "good first bug" label. I'd like to wait until we have something like that > before we start work on this again. Osmose: I see! Thanks for your comment.
Comment 12•6 years ago
|
||
Bumping this up to P2; I'm hearing more reports of queries behaving unexpectedly due to the time mismatch in the date filter.
Priority: P3 → P2
Assignee | ||
Comment 13•5 years ago
|
||
Couple of other people have been bitten by this. It's worth fixing. I'm going to grab it and see if I can get anywhere with it.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Updated•5 years ago
|
Assignee: mkelly → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 15•5 years ago
|
||
Assignee: nobody → willkg
Assignee | ||
Comment 16•5 years ago
|
||
willkg committed PR #4814 in d9d5fd8 https://github.com/mozilla-services/socorro/commit/d9d5fd857432964758c6213e0d14499c0f63a277
When that deploys to stage, I'll ask for help varifying it and making sure I didn't miss anything.
Assignee | ||
Comment 17•5 years ago
|
||
Email sent to stability asking for feedback. I'll see how that goes.
Assignee | ||
Comment 18•5 years ago
|
||
Liz said it looked good. I didn't hear from anyone else.
This went to prod just now in 364. Marking as FIXED.
If there are UX/UI nits we need to address to improve it, we can do that in new bugs.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 19•5 years ago
|
||
very nice
You need to log in
before you can comment on or make changes to this bug.
Description
•