Andreas Tolfsen ❲:ato❳ Assignee
	Description • 6 years ago

mozrunner is currently on winreg v0.3.4 but the latest version is v0.5.0.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 6 years ago

One thing I’m a bit uncertain about regardnig this change is that
it adds ~135k lines.  I’m sure the improvements are for the better,
but this presumably also means we need to compile a lot more things.
Since the current code is functioning as intended, I’m fine with
an r- on this patch.

	James Graham [:jgraham]
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8950260 [details]
Bug 1437571 - Upgrade to winreg v0.5.0.

https://reviewboard.mozilla.org/r/219518/#review226006

	James Graham [:jgraham]
	Comment 5 • 6 years ago
mozreview-review

Comment on attachment 8950261 [details]
Bug 1437571 - Bump winreg dependencies.

https://reviewboard.mozilla.org/r/219520/#review226008

Still is impossible to review :p I assume this was just the result of the vendor command.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 6 • 6 years ago

It looks like with winapi 0.3 you can pick what features you want to
include. winreg only picks a couple of these [1] so this should be
safe to land.

I also compared the average build times on TC with this patch
applied, and couldn’t see any significant change.

  [1] https://github.com/gentoo90/winreg-rs/blob/master/Cargo.toml#L13

	Pulsebot
	Comment 7 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8920ee351e02
Upgrade to winreg v0.5.0. r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b1a56d918b
Bump winreg dependencies. r=jgraham

	Andreea Pavel [:apavel]
	Comment 8 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8920ee351e02
https://hg.mozilla.org/mozilla-central/rev/f9b1a56d918b