Iulia Cristescu, QA [:JuliaC] (away, please needinfo? cornel.ionce@softvision.ro) Reporter
	Description • 6 years ago

[Affected versions]:
- 60.0a1 (2018-02-11)

[Affected platforms]:
- Windows 10 x64

[Steps to reproduce]:
1. Launch Firefox
2. Go to about:config and set "gfx.webrender.all" to true
3. Restart Firefox in order to have the changes made 
4. Close Firefox
5. Open Firefox, switch "gfx.webrender.all" back to false 
6. Restart Firefox in order to have the changes made 

[Expected result]:
- [step 4] [step 6] The "Firefox Nightly has stopped working" error is displayed (see the screenshot https://goo.gl/nVNzWs) 
- nothing happens when clicking the "Close the program" button 

[Actual result]:
- Firefox is successfully closed and no errors are triggered

[Regression range]:
- Additional details will be provided as soon as possible

[Additional notes]:
- I managed to reproduce this issue just on one station
- Here is the about:support https://goo.gl/4hgxBA

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 1 • 6 years ago

We want to make sure that ANGLE unsupported WebRender properly falls back and behaves as if WebRender was not enabled in the first place.  This bug is about fixing that.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 2 • 6 years ago

I could not reproduce the problem with STR in comment 0. But I could produce same "Firefox Nightly has stopped working" error ui with the following STR.

[1] Enable WebRender by setting "gfx.webrender.all" to true
[2] Go to about:support and push "Trigger Device Reset" button
    It made Firefox fallback to normal compositor, since Bug 1364504 is not addressed yet.
[3] Close Firefox.

At [3], I saw the error UI only with one my Window7 PC.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 3 • 6 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> I could not reproduce the problem with STR in comment 0. But I could produce
> same "Firefox Nightly has stopped working" error ui with the following STR.
> 
> [1] Enable WebRender by setting "gfx.webrender.all" to true
> [2] Go to about:support and push "Trigger Device Reset" button
>     It made Firefox fallback to normal compositor, since Bug 1364504 is not
> addressed yet.
> [3] Close Firefox.
> 
> At [3], I saw the error UI only with one my Window7 PC.

With a patch of Bug 1438408, I did not see the problem of comment 2 any more.

	Anca Soncutean, Desktop QA
	Comment 4 • 6 years ago

I tried to determine manually a regression  with the following results:
- Last good: 20171002220204
- First bad: 20171003100226 
- Pushlog: https://goo.gl/5xTria

Note that similar behaviour can also be reproduce between Nightly 58.0a1 (20171002220204) and Nightly 57.0a1 (20170919220202), when a warning security message is displayed several times when opening/closing Firefox before the error is triggered. 
Before this date, after setting the gfx.webrender.enabled on true (gfx.webrender.all was not available at that time) the browser won't restart, so I couldn't establish exactly when this issue starts reproducing.

	Marcia Knous [:marcia]
	Comment 5 • 6 years ago

Tracking 60 per triage discussion.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 6 • 6 years ago

Iulia Cristescu, can you still reproduce the problem with latest nightly?

I could not even reproduce Comment 3 since Bug 1438408 fix.

	Iulia Cristescu, QA [:JuliaC] (away, please needinfo? cornel.ionce@softvision.ro) Reporter
	Comment 7 • 6 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> Iulia Cristescu, can you still reproduce the problem with latest nightly?
> 
> I could not even reproduce Comment 3 since Bug 1438408 fix.

I can confirm that the issue is not reproducible anymore on the affected environment using the steps mentioned in comment 0.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 8 • 6 years ago

Close this bug with comment 7.

	Henrik Winnemöller
	Comment 9 • 6 years ago

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build-ID: 20180321220044

I can still reproduce this issue on my machine when setting gfx.webrender.force-angle to false. I do not know why, but these crashes only get logged in the event log of Windows 10. Thus, I also still see https://bugzilla.mozilla.org/show_bug.cgi?id=1437559

Crash Details from event log:
#1
"- System 
  - Provider 
   [ Name]  Application Error 
  - EventID 1000 
   [ Qualifiers]  0 
   Level 2 
   Task 100 
   Keywords 0x80000000000000 
  - TimeCreated 
   [ SystemTime]  2018-03-22T07:39:45.424562800Z 
   EventRecordID 7852 
   Channel Application 
   Computer ###-PC 
   Security 
- EventData
   firefox.exe 
   61.0.0.6654 
   5ab2e596 
   nvoglv64.DLL 
   21.21.13.4201 
   58298653 
   c0000005 
   000000000095f254 
   1d8c 
   01d3c1b0b36b1966 
   C:\Program Files\Firefox Nightly\firefox.exe 
   C:\WINDOWS\SYSTEM32\nvoglv64.DLL 
   05f4e29a-faf4-44c1-9445-9cdd5d0c66c5"
    
and

#2
"- System 
  - Provider 
   [ Name]  Application Error 
  - EventID 1000
   [ Qualifiers]  0 
   Level 2 
   Task 100 
   Keywords 0x80000000000000 
  - TimeCreated
   [ SystemTime]  2018-03-22T07:39:48.783948800Z 
   EventRecordID 7854 
   Channel Application 
   Computer ###-PC 
   Security
- EventData 
   firefox.exe 
   61.0.0.6654 
   5ab2e596 
   ntdll.dll 
   10.0.16299.248 
   effc9126 
   c0000409 
   00000000000a4c20 
   1d8c 
   01d3c1b0b36b1966 
   C:\Program Files\Firefox Nightly\firefox.exe 
   C:\WINDOWS\SYSTEM32\ntdll.dll 
   20c27cd5-0d79-4287-a7cd-0ebd46252391"

The nvoglv64.DLL has been the culprit of many recent issues (see https://bugzilla.mozilla.org/show_bug.cgi?id=1447037 and https://bugzilla.mozilla.org/show_bug.cgi?id=1437559). I'm aware that setting gfx.webrender.force-angle to false has no priority right now (see https://bugzilla.mozilla.org/show_bug.cgi?id=1446681#c7).