Dave Hunt [:davehunt] [he/him] ⌚BST Reporter
	Description • 6 years ago

The documentation at https://firefox-source-docs.mozilla.org/testing/geckodriver/geckodriver/TraceLogs.html links to the README as a relative URL, which causes the invalid URL of https://firefox-source-docs.mozilla.org/testing/geckodriver/README.md to be opened, resulting in a 404 not found.

	Dave Hunt [:davehunt] [he/him] ⌚BST Reporter
	Comment 1 • 6 years ago

We could link to the canonical source at https://hg.mozilla.org/mozilla-central/file/tip/testing/geckodriver/README.md, but this does not render the Markdown. Alternatively, we could link to the source on GitHub at https://github.com/mozilla/geckodriver/blob/master/README.md, but this appears to be out of sync with m-c.

Other options would be to pull in the contents of the README when we build the documentation and link to that, or to move the documentation from the README, and to link from the README to our canonical docs.

	Dave Hunt [:davehunt] [he/him] ⌚BST Reporter
	Comment 2 • 6 years ago

Henrik: Do you have a preference?

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 4 • 6 years ago

Andreas did most of the documentation work. Lets see what he thinks about it. For myself it would be fine to link to the Github version.

	Andreas Tolfsen ❲:ato❳
	Comment 5 • 6 years ago

Well spotted!  I think we should link to
https://searchfox.org/mozilla-central/source/testing/geckodriver/README.md.

	Andreas Tolfsen ❲:ato❳
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8949056 [details]
Bug 1436346 - Fix broken link to geckodriver README in TraceLogs docs;

https://reviewboard.mozilla.org/r/218458/#review224534

	Pulsebot
	Comment 8 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afdc0474181d
Fix broken link to geckodriver README in TraceLogs docs; r=ato

	Raphael Aurich [:raphael] UTC+02:00 Assignee
	Comment 9 • 6 years ago
mozreview-review-reply

Comment on attachment 8949056 [details]
Bug 1436346 - Fix broken link to geckodriver README in TraceLogs docs;

https://reviewboard.mozilla.org/r/218458/#review224534

Thank you :ato!

	Cosmin Sabou [:CosminS]
	Comment 10 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/afdc0474181d