Closed
Bug 1435789
Opened 6 years ago
Closed 6 years ago
Deprecate RTCIceCandidateStats.mozLocalTransport and add protocol and relayProtocol
Categories
(Core :: WebRTC: Networking, enhancement, P3)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: ng, Assigned: ng)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
There is a comment in RTCStatsReport.webidl RTCIceCandidates that mozLocalTransport needs statndardizing [1]. The line was added in bug 970690. [1] https://searchfox.org/mozilla-central/rev/01d663157f5796f0280f8b68f2308e7c19dd72c6/dom/webidl/RTCStatsReport.webidl#157 Could someone familiar with the field comment as to whether it still needs a bug filed against the spec?
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(drno)
Flags: needinfo?(docfaraday)
Comment 1•6 years ago
|
||
It looks like the spec is covering this a little differently than we are. The spec has two attributes, "protocol" and "relayProtocol". "protocol" is set to the transport protocol of the candidate (ie; what the other end will use to reach us). In the case of relay, this might be different from the local transport protocol, which will be stored in "relayProtocol". Otherwise, "relayProtocol" won't be set. In other words, c.mozLocalTransport = c.relayProtocol || c.protocol.
Flags: needinfo?(docfaraday)
Assignee | ||
Comment 2•6 years ago
|
||
Thanks, Byron. Ok, I am changing this bug to deprecating what we have in favor of implementing the spec.
Flags: needinfo?(drno)
Summary: Standardize RTCIceCandidateStats.mozLocalTransport → Deprecate RTCIceCandidateStats.mozLocalTransport and add protocol and relayProtocol
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → na-g
Comment 3•6 years ago
|
||
Nico, please add appropriate priorities for this one, it's unclear if it's short or long term. Also, can you move it to the right component? Thanks!
Flags: needinfo?(na-g)
Assignee | ||
Updated•6 years ago
|
Rank: 25
Component: WebRTC → WebRTC: Networking
Flags: needinfo?(na-g)
Priority: -- → P3
Comment 4•6 years ago
|
||
relayProtocol is the standardized variant of mozLocalTransport. Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-relayprotocol IDL: https://w3c.github.io/webrtc-stats/#icecandidate-dict*
Comment 5•6 years ago
|
||
is there a good way to have a relayed connection in the test?
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9001318 [details] Bug 1435789: implement relayProtocol for localcandidate stats Nico Grunbaum [:ng] has approved the revision.
Attachment #9001318 -
Flags: review+
Comment 7•6 years ago
|
||
Comment on attachment 9001318 [details] Bug 1435789: implement relayProtocol for localcandidate stats Olli Pettay [:smaug] has approved the revision.
Attachment #9001318 -
Flags: review+
Pushed by jbruaroey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b32ff85f2224 implement relayProtocol for localcandidate stats r=smaug,ng
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b32ff85f2224
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
Keywords: dev-doc-needed
Comment 10•6 years ago
|
||
Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/rtcicecandidatestats-mozlocaltransport-has-been-deprecated/
Keywords: site-compat
Comment 11•6 years ago
|
||
Note to docs team: I've added a note to the Fx 64 rel notes to cover this: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#APIs Doesn't look like we've documented RTCIceCandidateStats at all, so there's a bit of work to do here.
Comment 12•5 years ago
|
||
Documentation has been written. Pages added: https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/address https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/relayProtocol mozLocalTransport is set up as a redirect to relayProtocol as well. Change already on Firefox 64 for developers, as mentioned above.
Keywords: dev-doc-needed → dev-doc-complete
Comment 13•5 years ago
|
||
Replaced that redirect with an actual page with more useful info, since it's not a 1:1 replacement: https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/mozLocalTransport
Comment 14•5 years ago
|
||
Oh yeah, also added: https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•