Closed
Bug 1434219
Opened 6 years ago
Closed 6 years ago
Use marionette.port preference
Categories
(Testing :: Reftest, enhancement)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
The reftest harness in layout/tools/reftest/runreftest.py uses the marionette.defaultPrefs.port preference which has been deprecated for some time (since Firefox 55). We will want to change this to maronette.port.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8946634 [details] Bug 1434219 - Use current Marionette prefs in reftest harness. https://reviewboard.mozilla.org/r/216620/#review222362 There is also a marionette.logging use at https://dxr.mozilla.org/mozilla-central/rev/474d58c9137360c0fa1c85cdd11e3313b33b7cad/testing/mochitest/runtests.py#1833 Are you updating that in a separate bug?
Attachment #8946634 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Ah, thanks! I can do that in a separate bug since this is filed in Testing :: Reftest. Can I flag you for review there?
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/431161e00569 Use current Marionette prefs in reftest harness. r=gbrown
Comment 5•6 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #3) > Ah, thanks! I can do that in a separate bug since this is filed > in Testing :: Reftest. Can I flag you for review there? Yes, sounds good.
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/431161e00569
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•