Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Description • 6 years ago

This changes the timebase and the clock that is used for timestamps reported on RTCRtpContributingSource and RTCRtpSynchronizationSource objects.

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

::: dom/media/tests/mochitest/test_peerConnection_audioSynchronizationSources.html:44
(Diff revision 1)
> -      ok(Number.isInteger(source.timestamp),
> -        `Synchronization source timestamp is int (${source.timestamp})`);
> +      ok(window.performance.now() + window.performance.timeOrigin -
> +         source.timestamp < 1000, // This large value is used because sometimes

I'd use 5000. 1 second isn't that much on some of our testing infra.

	Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Comment 4 • 6 years ago
mozreview-review-reply

Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

> I'd use 5000. 1 second isn't that much on some of our testing infra.

Going with 2500. If that isn't enough, it can be changed later.

	Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Comment 5 • 6 years ago

This work is required for supporting Google's Meet service working on Firefox, and brings our implementation closer to the spec changes around timestamps[0].

[0] https://github.com/w3c/webrtc-pc/issues/1690

	Pulsebot
	Comment 6 • 6 years ago

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/9b144f79e512
bring rtp sources js timestamp and timebase up to spec r=jib

	Cristina Coroiu [:ccoroiu]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9b144f79e512

	Eric Shepherd [:sheppy]
	Comment 8 • 6 years ago

Updated the compatibility data for RTCRtpContributingSource to note this change for Firefox 60, and added a mention to Firefox 60 for developers.