Closed Bug 1433497 Opened 6 years ago Closed 6 years ago

Move Marionette Python client to modern Marionette prefs

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

The Marionette Python client uses the old preferences such as
marionette.logging, instead of marionette.log.level.  We should move it
to use the prefs defined in testing/marionette/prefs/marionette.js so we
can remove the fallbacks in testing/marionette/components/marionette.js.
Assignee: nobody → ato
Blocks: 1432894
Comment on attachment 8945832 [details]
Bug 1433497 - Include new Marionette prefs in Python client.

https://reviewboard.mozilla.org/r/215944/#review221944

Indeed! Good catch. It might still be good to get the old prefs removed in the client for the next ESR (60). For which version did this change happen?
Attachment #8945832 - Flags: review?(hskupin) → review+
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 8945832 [details]
> Bug 1433497 - Include new Marionette prefs in Python client.
> 
> https://reviewboard.mozilla.org/r/215944/#review221944
> 
> Indeed! Good catch. It might still be good to get the old prefs removed in
> the client for the next ESR (60). For which version did this change happen?

I’d have to check to be sure, but I think, 55.
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ac99a988ffa
Include new Marionette prefs in Python client. r=whimboo
https://hg.mozilla.org/mozilla-central/rev/9ac99a988ffa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1434926
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: