Closed
Bug 1431155
Opened 6 years ago
Closed 6 years ago
Move WindowState to testing/marionette/browser.js
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
In preparation of the window tracking work I want to move the WindowState class from testing/marionette/wm.js, effectively leaving the file empty, to testing/marionette/browser.js. With patches for improving window tracking we will not have to expose WindowState outside browser.js, but moving it to that file first will make the patch a lot easier to read. This will mean that wm.js will essentially remain empty for a short period, however, I trust this is acceptable.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Blocks: marionette-window-tracking
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8943328 [details] Bug 1431155 - Move WindowState to Marionette browser module. https://reviewboard.mozilla.org/r/213658/#review219660 ::: testing/marionette/wm.js:7 (Diff revision 1) > * License, v. 2.0. If a copy of the MPL was not distributed with this file, > * You can obtain one at http://mozilla.org/MPL/2.0/. */ > > "use strict"; > > -this.EXPORTED_SYMBOLS = ["WindowState"]; > +this.EXPORTED_SYMBOLS = []; why arent you deleting this file?
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8943328 [details] Bug 1431155 - Move WindowState to Marionette browser module. https://reviewboard.mozilla.org/r/213658/#review219660 > why arent you deleting this file? I said in the bug, but we need it again for https://bugzil.la/marionette-window-tracking.
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8943328 [details] Bug 1431155 - Move WindowState to Marionette browser module. https://reviewboard.mozilla.org/r/213658/#review219668
Attachment #8943328 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4581da0d9525 Move WindowState to Marionette browser module. r=automatedtester
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ed62b395dc2 Backed out changeset 4581da0d9525 for failing Browser-chrome on browser/base/content/test/static/browser_all_files_referenced.js on a CLOSED TREE
Assignee | ||
Comment 7•6 years ago
|
||
So it turns out there is a browser chrome test for unused files that fails: https://treeherder.mozilla.org/logviewer.html#?job_id=157156338&repo=autoland&lineNumber=4940 I will remove the reference from testing/marionette/jar.mn for the time being.
Comment hidden (mozreview-request) |
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/abe10e265f29 Move WindowState to Marionette browser module. r=automatedtester
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/abe10e265f29
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•