Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Description • 6 years ago

The 2018/1/11 w3C TPAC interim, brought changes to the RTCRtpReceiver's getSynchronizationSources, and getContributingSources APIs that were recently added and are currently in Beta. We need to pref our implementation off for 59 so that those changes can be implemented, and landed in 60. A new preference "media.peerconnection.rtpsourcesapi.enable" is to be used for this.

	Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Comment 2 • 6 years ago

There are a few more days than I thought, so this bug is just to add the pref which will default to enabling the API. If the required changes can not be made in time, this pref can be used to disable the APIs.

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8942299 [details]
Bug 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;

https://reviewboard.mozilla.org/r/212584/#review218286

Lgtm. Don't forget DOM review.

::: commit-message-8460d:1
(Diff revision 2)
> +Bug - 1430213 - pref off RTCRtpReceiver RTP sources APIs;r?jib

Update commit message since we're no longer preffing off immediately.

	Nico Grunbaum [:ng, @chew:mozilla.org] Assignee
	Comment 6 • 6 years ago

WebIDL review info: this patch contains a new pref that will allow us to toggle support for getContributingSources and getSynchronizationSources

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8942299 [details]
Bug 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;

https://reviewboard.mozilla.org/r/212584/#review219880

	Mozilla Autoland
	Comment 8 • 6 years ago

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 1d4fe98db80e needs "Bug N" or "No bug" in the commit message.
remote: Nico Grunbaum
remote: Bug - 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;r=jib,smaug
remote: 
remote: MozReview-Commit-ID: 7vKUDDpjiP2
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote

	Pulsebot
	Comment 10 • 6 years ago

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/a228b6c6b7aa
add toggle pref for RTCRtpReceiver RTP sources APIs;r=jib,smaug

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a228b6c6b7aa

	Eric Shepherd [:sheppy]
	Comment 12 • 6 years ago

Documentation updated; this is now marked as disabled by default with info on the pref.