Closed Bug 1430152 Opened 6 years ago Closed 6 years ago

Move Rust mozversion crate from GitHub to central

Categories

(Testing :: Mozbase, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(2 files)

As with https://bugzil.la/1429511 we want to move the Rust
mozversion crate from GitHub [1] to central.  We will follow the
same approach outlined in that bug.

  [1] https://github.com/jgraham/mozversion
Assignee: nobody → ato
Blocks: 1401129
Comment on attachment 8942221 [details]
Bug 1430152 - Move geckodriver to in-tree mozversion.

https://reviewboard.mozilla.org/r/212496/#review218234
Attachment #8942221 - Flags: review?(james) → review+
Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

https://reviewboard.mozilla.org/r/212494/#review218558

::: testing/mozbase/rust/mozversion/.hgignore:2
(Diff revision 2)
> +target
> +Cargo.lock

I don't know about git, but I'm pretty sure that hg won't pick up this file. You could add these rules to the toplevel .hgignore/.gitignore files if it's important though (prefixed to testing/mozbase/rust of course).

Either way these ignore files should probably be removed.
Attachment #8942220 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

https://reviewboard.mozilla.org/r/212494/#review218558

> I don't know about git, but I'm pretty sure that hg won't pick up this file. You could add these rules to the toplevel .hgignore/.gitignore files if it's important though (prefixed to testing/mozbase/rust of course).
> 
> Either way these ignore files should probably be removed.

Thanks for pointing this out!  I’ve made the changes to topsrcdir’s
.hgignore file.

It is fine to leave the testing/mozbase/rust/mozversion/.gitignore
file as these are automatically picked up in git.
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/777ee4ac78e4
Move Rust port of mozversion to central. r=ahal
https://hg.mozilla.org/integration/autoland/rev/878662b94ba2
Move geckodriver to in-tree mozversion. r=jgraham
https://hg.mozilla.org/mozilla-central/rev/777ee4ac78e4
https://hg.mozilla.org/mozilla-central/rev/878662b94ba2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: