Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Description • 6 years ago

Bug 1393831 changed the way how we calculate the default position for elements to match the WebDriver spec. Basically it changed it from top/left to the in center view point.

Given that this causes problems for some Selenium bindings, we need a fallback and as agreed via a vendor capability.

With Maja we agreed on `moz:useNonSpecCompliantPointerOrigin`.

As we wondered it might be good if geckodriver just could pass through all of those vendor capabilities, so that we don't have to release a new geckodriver version each time.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 2 • 6 years ago

Marking as P2 to allow a fallback for users who have to rely on the old (non webdriver spec) behavior.

	Andreas Tolfsen ❲:ato❳
	Comment 3 • 6 years ago
mozreview-review

Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

The code change looks good, but I have a question.

::: testing/geckodriver/README.md:297
(Diff revision 1)
> +Please note that this capability exists only temporarily, and that it will be
> +removed once all vendors updated their existent drivers to match the [WebDriver]
> +specification.

I thought the migration path was for the Selenium clients to update
their shims?

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 4 • 6 years ago
mozreview-review-reply

Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

> I thought the migration path was for the Selenium clients to update
> their shims?

Oh yes, basically for us! But other vendors also have to update their drivers. So we should include both.

	Andreas Tolfsen ❲:ato❳
	Comment 6 • 6 years ago
mozreview-review

Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219674

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 7 • 6 years ago
mozreview-review-reply

Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

> Oh yes, basically for us! But other vendors also have to update their drivers. So we should include both.

Well, lets remove other vendors. We don't actually care about that, when the bindings handle our new behavior correctly.

	Pulsebot
	Comment 8 • 6 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d97649d30062
Add vendor capability for old Pointer Origin behavior. r=ato

	Andrei Ciure[:aciure]
	Comment 9 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d97649d30062