Andreas Tolfsen ❲:ato❳ Assignee
	Description • 6 years ago

The window tracking refactoring introduces new “ContentContext”
and “ChromeContext” abstractions that smoothen over the divide
of having to deal with ChromeWindow and <xul:browser>/browser.Context
through convoluted if-conditions.

As part of this change it also unifies the assert.contentBrowser and
assert.window assertions because both ContentContext and ChromeContext
share the same interface.  Because they both expose a “closed”
getter, it is possible to use the same assertion.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 3 • 6 years ago
mozreview-review

Comment on attachment 8942174 [details]
Bug 1430109 - Combine assert.window and assert.contentBrowser.

https://reviewboard.mozilla.org/r/212452/#review218280

A couple of typos.

::: commit-message-d2edd:5
(Diff revision 2)
> +Bug 1430109 - Combine assert.window and assert.contentBrowser. r?maja_zf
> +
> +The forthcoming window tracking refactoring introduces the new
> +abstractions ContentContext and ChromeContext that to a large extent
> +share the same interface.  They make it possible to interct with

s/interct/interact/

::: testing/marionette/assert.js:137
(Diff revision 2)
> - * @param {ChromeWindow} win
> - *     Chrome window to test.
> - * @param {string=} msg
> - *     Custom error message.
>   *
> - * @return {ChromeWindow}
> + * When passed a {@link ChromeContext} this is equivalent to testing

Shouldn't this be "When passed in a ChromeWindow"?

	Pulsebot
	Comment 5 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8ae7190dd15
Combine assert.window and assert.contentBrowser. r=maja_zf

	Noemi Erli[:noemi_erli]
	Comment 6 • 6 years ago

Backed out changeset e8ae7190dd15 (bug 1430109) for Wr failures in /builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py on a CLOSED TREE

Push that was backed out: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e8ae7190dd15d67766b396320de894120faa5734&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=success

https://treeherder.mozilla.org/logviewer.html#?job_id=156255171&repo=autoland&lineNumber=1316

Backout: https://hg.mozilla.org/integration/autoland/rev/74055b2dab456b891e2d373e9999186639bc1ebc

	Pulsebot
	Comment 7 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b67c5b1e033b
Combine assert.window and assert.contentBrowser. r=maja_zf

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 8 • 6 years ago

I missed updating a reference in testing/marionette/reftest.js.

	David Burns :automatedtester
	Comment 9 • 6 years ago

[Mass update] Setting P1 as currently being worked on.

	Natalia Csoregi [:nataliaCs]
	Comment 10 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/b67c5b1e033b