Andreas Tolfsen ❲:ato❳ Assignee
	Description • 6 years ago

Because there is only one consumer of the Rust port of mozrunner
the suggestion is to move it from GitHub [1] to central so it gets
better test coverage through testing with geckodriver.

The proposed new home for it is testing/mozbase/rust/mozrunner.
Other proposals are welcome.

  [1] https://github.com/jgraham/rust_mozrunner

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 6 years ago

jgraham: I am wondering if you have any additional comments about this.
Otherwise I will follow the same procedure as last time we put the
webdriver crate in central.

	James Graham [:jgraham]
	Comment 2 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=95bc351cc476fbbed7969b236f7067791d1d1af1 is the import I did with no history. I'm not sure how valuable the commit history is here, so I would only bother to preserve it if doing so is trivial.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 6 years ago

I agree with the assessment that the commit history might not be so important.

	James Graham [:jgraham]
	Comment 9 • 6 years ago
mozreview-review

Comment on attachment 8942225 [details]
Bug 1429511 - Update mozrunner crate repo URL.

https://reviewboard.mozilla.org/r/212498/#review218230

	James Graham [:jgraham]
	Comment 10 • 6 years ago
mozreview-review

Comment on attachment 8942216 [details]
Bug 1429511 - Move geckodriver to in-tree mozrunner.

https://reviewboard.mozilla.org/r/212484/#review218232

	Andrew Halberstadt [:ahal]
	Comment 11 • 6 years ago
mozreview-review

Comment on attachment 8942215 [details]
Bug 1429511 - Move Rust port of mozrunner to central.

https://reviewboard.mozilla.org/r/212482/#review218560

::: testing/mozbase/rust/mozrunner/.hgignore:2
(Diff revision 1)
> +target/
> +Cargo.lock

Same comment as for mozversion. Hg won't pick this file up in a subdirectory. You can put these rules in the top level .hgignore file if they're important.

	Andrew Halberstadt [:ahal]
	Comment 12 • 6 years ago
mozreview-review-reply

Comment on attachment 8942215 [details]
Bug 1429511 - Move Rust port of mozrunner to central.

https://reviewboard.mozilla.org/r/212482/#review218560

> Same comment as for mozversion. Hg won't pick this file up in a subdirectory. You can put these rules in the top level .hgignore file if they're important.

Looks like .hgignore supports an include syntax:
subinclude:testing/mozbase/rust/mozrunner/.hgignore

But we hardly use that in our root .hgignore, so it might be best to just be consistent with the rest of the file.

	Mozilla Autoland
	Comment 16 • 6 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8aaf86fc1effd73b4e850346d5d7fc4d381dc559 -d 878662b94ba2: rebasing 442895:8aaf86fc1eff "Bug 1429511 - Move Rust port of mozrunner to central. r=ahal"
rebasing 442896:6fb5275d4f93 "Bug 1429511 - Move geckodriver to in-tree mozrunner. r=jgraham"
merging testing/geckodriver/Cargo.lock
merging testing/geckodriver/Cargo.toml
warning: conflicts while merging testing/geckodriver/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/geckodriver/Cargo.toml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 17 • 6 years ago

Need to wait for bug 1430152 to land because they change the same
file and hg isn’t clever enough to understand it’s not the same line.

	Mozilla Autoland
	Comment 18 • 6 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8aaf86fc1effd73b4e850346d5d7fc4d381dc559 -d f390f152d0ac: rebasing 443008:8aaf86fc1eff "Bug 1429511 - Move Rust port of mozrunner to central. r=ahal"
merging .hgignore
rebasing 443009:6fb5275d4f93 "Bug 1429511 - Move geckodriver to in-tree mozrunner. r=jgraham"
merging testing/geckodriver/Cargo.lock
merging testing/geckodriver/Cargo.toml
warning: conflicts while merging testing/geckodriver/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/geckodriver/Cargo.toml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

	Pulsebot
	Comment 22 • 6 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5af72ae23d96
Move Rust port of mozrunner to central. r=ahal
https://hg.mozilla.org/integration/autoland/rev/f0180c3c7af7
Move geckodriver to in-tree mozrunner. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/f89e3bba65ec
Update mozrunner crate repo URL. r=jgraham

	Andrei Ciure[:aciure]
	Comment 23 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5af72ae23d96
https://hg.mozilla.org/mozilla-central/rev/f0180c3c7af7
https://hg.mozilla.org/mozilla-central/rev/f89e3bba65ec