Pete Moore [:pmoore][:pete] Reporter
	Description • 6 years ago

For "expensive" CIs that do a lot of processing, this is a bit unnecessary.

I think we only want to rerun tasks if the commit SHA changes. Optionally, we could allow a setting in .taskcluster.yml to run for any PR event (e.g. maybe task queries PR title in some bizarre use case) - but that really is probably just fine tuning something that is already fine tuning. xD

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 1 • 6 years ago

The fix is to remove the pull_request.edited option from your .taskcluster.yml
  https://docs.taskcluster.net/reference/integrations/taskcluster-github/docs/taskcluster-yml-v0

	Pete Moore [:pmoore][:pete] Reporter
	Comment 2 • 6 years ago

My bad, thanks!

	[github robot]
	Comment 3 • 6 years ago

Commit pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/5e58d570d00b87dd4984b0f5afbc4aa52a35196f
Bug 1429370 - don't execute on on github 'pull_request.*' events - only 'pull_request'.

	[github robot]
	Comment 4 • 6 years ago

Commit pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/c01f831e4f81c31e81c8ecefd1e032d7a1c9436d
Bug 1429370 - fix