Closed
Bug 1429082
Opened 6 years ago
Closed 6 years ago
Remove unused classes from proxy module
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(2 files)
There are several unused IPC helper classes in testing/marionette/proxy.js that can now be removed in their entirety.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Blocks: marionette-window-tracking
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8941088 [details] Bug 1429082 - Drop AsyncChromeSender from proxy module. https://reviewboard.mozilla.org/r/211358/#review217270 ::: commit-message-6f5fa:4 (Diff revision 1) > +Bug 1429082 - Drop AsyncChromeSender from proxy module. r?whimboo > + > +The AsyncChromeSender and its factory construction function > +proxy.toChromeAsync are no longer in use. When I search under testing/marionette I can still find it in the docs. Can you please make sure to regenerate those? Also you said this is done via a cron job, but that code was removed 3 months ago via bug 1405279. Is that busted?
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8941088 [details] Bug 1429082 - Drop AsyncChromeSender from proxy module. https://reviewboard.mozilla.org/r/211358/#review217272
Attachment #8941088 -
Flags: review?(hskupin) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8941089 [details] Bug 1429082 - Drop SyncChromeSender from proxy module. https://reviewboard.mozilla.org/r/211360/#review217274 Great to see this cleanup!
Attachment #8941089 -
Flags: review?(hskupin) → review+
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3) > When I search under testing/marionette I can still find it in the > docs. Can you please make sure to regenerate those? Also you said > this is done via a cron job, but that code was removed 3 months > ago via bug 1405279. Is that busted? Thanks for reminindg me. I never enabled the cron job because I wasn’t entirely confident in its reliability. Since then someone wrote to dev-platform@ about integrating jsdoc with Sphinx and the Firefox source docs. I will research that some more tomorrow and also regenerate the docs.
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6295a6ab95a Drop AsyncChromeSender from proxy module. r=whimboo https://hg.mozilla.org/integration/autoland/rev/2224eacab99e Drop SyncChromeSender from proxy module. r=whimboo
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6295a6ab95a https://hg.mozilla.org/mozilla-central/rev/2224eacab99e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•