Closed Bug 1427800 Opened 6 years ago Closed 6 years ago

Wrong anchor scrolling with old UI

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: away, Assigned: kohei)

References

Details

Attachments

(1 file)

45 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
STR:
1. Set the old (left-aligned) theme
2. Open bug 1235982
3. Scroll so that the 85th comment is at the top of the screen (I am deliberately not linking to it, in case that interferes with the repro)
4. Click the link that refers to the 81st comment

Expected: Scrolls to 81st comment
Actual: Scrolls to roughly 73rd comment
What's our timeline to turn off the old (non-bug-modal) view? 

If we're getting rid of this soon, I'd wontfix this one.

If we're keeping it around, then this bug needs a priority.
Flags: needinfo?(kohei.yoshino)
The non-modal view should be removed sometime soon for further UX work, but I see the current script, namely the `offsetTop` property, is somewhat unreliable, so it could be broken in the modal view as well when CSS is modified. Will fix this anyway.

https://github.com/mozilla-bteam/bmo/blob/master/js/global.js#L221
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Flags: needinfo?(kohei.yoshino)
Attached file pull request
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: