Closed
Bug 1425317
Opened 6 years ago
Closed 6 years ago
Hook geckodriver up to mach build and test commands
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
We want to provide aliases that hook geckodriver building and testing up to the "./mach build testing/geckodriver" and "./mach test testing/geckodriver" commands. This is a follow-up from [1] based on the discussion in [2]. [1] https://bugzil.la/1420472 [2] https://groups.google.com/forum/#!topic/mozilla.tools.marionette/bxdbul_RDDc
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8937263 [details] Bug 1425317 - Hook geckodriver up to mach's test command. https://reviewboard.mozilla.org/r/207950/#review214452 Lgtm. The alias hack is clever, though it won't work if you pass in a subdir or testing/geckodriver. I still think that figuring out how to integrate these tests into the build system is the way to go, but understand that's a lot of work for minimal benefit. So this looks fine for now. ::: testing/geckodriver/CONTRIBUTING.md:157 (Diff revision 1) > [Web Platform Tests] (WPT) initiative. This lets us ensure web > compatibility between _different_ WebDriver implementations for > different browsers. > > In addition to the WPT tests, geckodriver and webdriver have unit tests. > -You can also use the mach geckodriver command to run geckodriver tests: > +Like with building, you can use the mach command to run them: nit: you can use a mach command ::: testing/mozbase/moztest/moztest/resolve.py:53 (Diff revision 1) > 'mach_command': 'check-spidermonkey', > 'kwargs': {'valgrind': False}, > }, > + 'geckodriver': { > + 'mach_command': 'geckodriver-test', > + 'aliases': ('testing/geckodriver',), This is hacky, though I also don't want to block you on proper build system integration. At least add: # TODO Integrate geckodriver tests with moz.build
Attachment #8937263 -
Flags: review?(ahalberstadt) → review+
Comment hidden (mozreview-request) |
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f73719c150e6 Hook geckodriver up to mach's test command. r=ahal
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f73719c150e6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•