Closed Bug 1424263 Opened 6 years ago Closed 6 years ago

Safe Browsing updates fail when the folder is open on Windows

Categories

(Toolkit :: Safe Browsing, defect, P3)

All
Windows
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fix-optional
firefox61 --- fix-optional

People

(Reporter: obotisan, Unassigned)

Details

Attachments

(3 files)

[Affected versions]:
- Firefox 57.0
- beta 58.b010
- latest Nightly 59

[Affected platforms]:
- Windows 10 x64
- Windows 8.1 x32
- Ubuntu 16.04 x32

[Steps to reproduce]:
1. Reset Firefox browse. IMPORTANT For Safe Browsing v4 empty "google4" folder.
2. Empty safebrowsing v4 DB, after that close the folder
         - (1) Linux: ~/.cache/mozilla/firefox/XXXX/safebrowsing/google4 
         - (3) Windows: C:\Users\XXXX\AppData\Local\mozilla\firefox\profiles\XXXX\safebrowsing\google4 
3. Go to about:url-classifier page
4. Press Trigger Update for google 4
5. Disconnect the internet connection when the status is updating.
6. Reconnect to the internet.
7. Restart the browser open about:url-classifier again.
8. Press "Trigger Update" again.

[Expected result]:
- Last update status should be "success". Safebrowsing v4 DB is updated.

[Actual result]:
- Google4 still displays the error and after a while it shows the message "Cannot Update"

[Regression range]:
- I don't know if this is a regression, but I will try to find as soon as possible.
Dimi, can you look into this bug?
Flags: needinfo?(dlee)
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Flags: needinfo?(dlee)
Regression range

- last good build: 20171029220112 (2017-10-29)
- first bad build: 20171030103605 (2017-10-30)
- pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d3910b7628b8066d3f30d58b17b5824b05768854&tochange=515407ebfa1433c31144374313bbfd8b942af41c

 I hope this information is useful, because I had to find the regression manually. Mozregression didn't want to cooperate with me on this issue.
Keywords: regression
Hi Oana,
I tried to reproduce this on my ubuntu platform but I can't reproduce it.
I would like to check the reproduce step with you.

For step5, did you see "update error(xxxx)" in update status field?
For step7, did you restart the browser? or you just press update after reconnecting to internet.

is it possible to have a video to see how you reproduce this one?

Thanks for your help!
Flags: needinfo?(oana.botisan)
Attached image google4 - 1.gif
To answer your question first. I see the error. Only it wasn't 500 error. You can see in the screen capture which error.

After I reconnected the internet I restarted the browser.

But today for some reason I could only reproduce this bug on Windows. I couldn't reproduce it on Ubuntu anymore.

For disconnecting the internet connection I used two different methods, which I think might have discovered another bug.
   1. I pulled out the internet cable
Flags: needinfo?(oana.botisan)
Attached image google4.gif
2. I used the program Net Limiter. Here I had to limit the internet connection first in order for me to kill it (the internet speed is too high and the program updated before I could kill the connection)

 Using this method I noticed the same error being displayed, even without killing the connection. Which means that if the internet speed is really slow, then the program won't update. Is this a different issue? Should I log another bug for this?
(In reply to Oana Botisan from comment #4)
> Created attachment 8936413 [details]
> google4 - 1.gif
> 
> To answer your question first. I see the error. Only it wasn't 500 error.
> You can see in the screen capture which error.
> 
> After I reconnected the internet I restarted the browser.
> 

Thanks for quick response, Oana!
That is interesting, from the screen capture we can see that the "Cannot Update" in step 8 is because of Backoff.
But you have restarted the browser so we shouldn't have this issue...

I also cannot reproduce this on my windows platform with the latest build.

Could you help me record the video again with.
1. Your machine's local time (From the windows toolbar)
2. After you restart, I want to see the whole window of about:url-classifier (it is blocked in the first video)

Another question is that did you launch firefox with -no-remote argument, could you help check this issue without it?

Really appreciate for helping this.
Flags: needinfo?(oana.botisan)
Attached image google4 - 2.gif
Sorry I didn't respond sooner, but I had a lot of work.
You can find attached the video with everything you asked me.
I opened the browser with and without using -no-remote. And without I mean double-click on the icon.
Flags: needinfo?(oana.botisan)
Hi Onana,
Thanks for the information, It's a little bit hard to debug this if I can't reproduce this one.
I'll try to find a platform that can reproduce this one.
Priority: -- → P3
Assignee: dimidiana → nobody
Status: ASSIGNED → NEW
Oana, when you get a chance, can you please confirm whether this is still reproducible? Thanks!
Flags: needinfo?(oana.botisan)
I tested it on Firefox 61.0a1 using Windows 10 x64 and the bug is still reproducing. 
But I noticed something else too, the bug is still reproducing only when the "google4" folder is still opened. If I close the folder after it's empty, the update is made successfully.
Flags: needinfo?(oana.botisan)
(In reply to Oana Botisan from comment #10)
> I tested it on Firefox 61.0a1 using Windows 10 x64 and the bug is still
> reproducing. 
> But I noticed something else too, the bug is still reproducing only when the
> "google4" folder is still opened. If I close the folder after it's empty,
> the update is made successfully.

So in other words, this problem only occurs on Windows when the folder is open and therefore locked by the OS.

Once you close the folder, do the updates start working again automatically or does it get stuck until the next browser restart?
Flags: needinfo?(oana.botisan)
It updates after the initial restart. I think I left it for about half an hour and it updated. 
So now I think the bug is reproducing only when the folder is opened.
Flags: needinfo?(oana.botisan)
(In reply to Oana Botisan from comment #12)
> So now I think the bug is reproducing only when the folder is opened.

Thanks for the confirmation Oana.

I don't think there's much we can do there since it's a Windows limitation. At least updates start working again once the folder is closed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
I'm pretty sure this was a problem with version 2 of the Safe Browsing protocol too.
Keywords: regression
OS: All → Windows
Summary: [Safe Browsing] Google4 cannot update if the internet connection is disconnected while the file is downloading and then reconnected. → Safe Browsing updates fail when the folder is open on Windows
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: