Closed Bug 1423359 Opened 7 years ago Closed 6 years ago

Marionette:listenersAttached does not need to be registered globally

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ato, Assigned: ato)

References

Details

The Marionette:listenersAttached IPC message listener is currently
registered for the entire lifetime of the GeckoDriver session.  We
only need to listen for it during the scope of
GeckoDriver#listeningPromise, where it is also set up and (appropriately)
removed.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Depends on: 1423282
My understanding of Marionette:listenersAttached was wrong.  It is used
to flush the pending command queue for the content browser, which is used
whenever a content browser suffers a remoteness change as it is processing
a message sent from chrome space.  We a likely to still need this despite
https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking.

I have filed https://bugzilla.mozilla.org/show_bug.cgi?id=1426154
to make the this.curBrowser.pendingCommands queue better, however.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.