Closed
Bug 1422593
Opened 6 years ago
Closed 6 years ago
Pretty print WindowProxy and ChromeWindow
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
In addition to pretty-printing elements and arbitrary objects, it would be good to provide pretty-printing for WindowProxies and ChromeWindows.
Assignee | ||
Updated•6 years ago
|
Blocks: marionette-window-tracking
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
These values currently get printed as "[object ChromeWindow] <cyclic object value>", so I think this is a worthwhile improvement to make.
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8933996 [details] Bug 1422593 - Pretty print WindowProxy and ChromeWindow. https://reviewboard.mozilla.org/r/204908/#review210528 ::: testing/marionette/format.js:89 (Diff revision 1) > - s = prettyElement(val); > - } else { > - s = prettyObject(val); > - } > } catch (e) { > - s = typeof val; > + log.warn("Problem pretty printing", e); nit: Lets add a ":" to separate the message from the paramter value.
Attachment #8933996 -
Flags: review?(hskupin) → review+
Comment hidden (mozreview-request) |
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a1380c561f1 Pretty print WindowProxy and ChromeWindow. r=whimboo
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3a1380c561f1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•