Open Bug 1422306 Opened 6 years ago Updated 5 years ago

arc diff inserts whitespace into strings upon first time configuration

Categories

(Conduit :: General, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: ato, Unassigned)

Details

(Keywords: conduit-triaged)

When I ran "arc diff" for the first time it asked me to configure
the default commit range.  I thought "central", which is my local
git branch tracking the remote mozilla-central hg repository,
would be a good fit.

However, when entering "central" in the command prompt, it inserted
a number of spaces into the string.  I think this is because arc
does not support dumb terminals (where TERM=dumb is set).

> % arc diff
> You have untracked files in this working copy.
> 
>   Working copy: [4m/home/ato/src/gecko/[m
> 
>   Untracked changes in working copy:
>   (To ignore this change, add it to ".git/info/exclude".)
>     .arcconfig
> 
>     Ignore this untracked file and continue? [y/N] y
> 
> [42m[1m Select a Default Commit Range [m[49m
> 
> You're running a command which operates on a range of revisions (usually,
> from some revision to HEAD) but have not specified the revision that should
> determine the start of the range.
> 
> Previously, arc assumed you meant 'HEAD^' when you did not specify a start
> revision, but this behavior does not make much sense in most workflows
> outside of Facebook's historic git-svn workflow.
> 
> arc no longer assumes 'HEAD^'. You must specify a relative commit explicitly
> when you invoke a command (e.g., `arc diff HEAD^`, not just `arc diff`) or
> select a default for this working copy.
> 
> In most cases, the best default is 'origin/master'. You can also select
> 'HEAD^' to preserve the old behavior, or some other remote or branch. But you
> almost certainly want to select 'origin/master'.
> 
> (Technically: the merge-base of the selected revision and HEAD is used to
> determine the start of the commit range.)
> 
>     What default do you want to use? [origin/master]     central
> [41m[1m Exception [m[49m
> Command failed with error #128!
> COMMAND
> git cat-file -t '    central'
> 
> STDOUT
> (empty)
> 
> STDERR
> fatal: Not a valid object name     origin/central
> 
> (Run with `--trace` for a full exception trace.)

If I press backspace four or five times before entering "central",
I was able to successfully configure "arc diff".
Keywords: conduit-triaged
Whiteboard: [lando-backlog]
Keywords: conduit-backlog
Whiteboard: [lando-backlog]
Keywords: conduit-backlog
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.