Closed Bug 1420431 Opened 7 years ago Closed 7 years ago

get_active_element.py’s test_success_without_body is wrong

Categories

(Testing :: geckodriver, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(2 files)

The WPT test test_success_without_body in get_active_element.py is wrong.
It expects Get Active Element to return null if there is no document
element, but following https://github.com/w3c/webdriver/pull/1157
we want it to return a no such element error.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8931713 [details]
Bug 1420431 - Allow WebElement to be returned from GeckoDriver.

https://reviewboard.mozilla.org/r/202846/#review208504
Attachment #8931713 - Flags: review?(mjzffr) → review+
Comment on attachment 8931714 [details]
Bug 1420431 - Return no such element error when on no active element.

https://reviewboard.mozilla.org/r/202848/#review208510
Attachment #8931714 - Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b02b1a3ba1a5
Allow WebElement to be returned from GeckoDriver. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/a0fdf492fb37
Return no such element error when on no active element. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/b02b1a3ba1a5
https://hg.mozilla.org/mozilla-central/rev/a0fdf492fb37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: