Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 7 years ago

Bug #1419856 implemented the /__version__ endpoint, but we need /__heartbeat__ and /__lbheartbeat__ to finish up the Dockerflow bits.

This bug covers implementing those.

One thing we might want to think about is ditch our /__version__ implementation and switch to python-dockerflow and implement all three that way.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 7 years ago

Miles reminded me that while it's nice to have these endpoints on the webapp, it's better to have them on all the apps. We should think about that either as part of this bug or as another bug.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 7 years ago

Need to implement this for the new infra. Making it a P2.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 6 years ago

We're using existing endpoints for now. I would like to swap those out for more Dockerflow-like ones at some point, but we can do that after we migrate to the new infra.

Given that, I'm unblocking this bug.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 6 years ago

These need to be implemented in the webapp, so I'm moving it to that component.

	Issei Horie [:is2ei]
	Comment 5 • 6 years ago

Hi Will,

Could I work on this issue?

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 6 years ago

I originally thought this would be a straight-forward bug since we're just moving around views, but a bunch of stuff has changed since then and I think someone who knows our infrastructure to spend time on this to figure out what defines "unhealthy" and then implement that.

Given that, this isn't a good first bug anymore. I'm nixing it from that status.

Sorry about that!

	Issei Horie [:is2ei]
	Comment 7 • 6 years ago

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #6)
> I originally thought this would be a straight-forward bug since we're just
> moving around views, but a bunch of stuff has changed since then and I think
> someone who knows our infrastructure to spend time on this to figure out
> what defines "unhealthy" and then implement that.
> 
> Given that, this isn't a good first bug anymore. I'm nixing it from that
> status.
> 
> Sorry about that!

Ok! Thanks for your comment.