Osmose [:osmose, :mkelly] Reporter
	Description • 7 years ago

The following warning is captured and logged during the test run:

socorro/unittest/cron/jobs/test_bugzilla.py::IntegrationTestBugzilla::test_basic_run_job
  /usr/local/lib/python2.7/site-packages/configman/config_manager.py:862: UserWarning: Invalid options: logger
    'Invalid options: %s' % ', '.join(sorted(unmatched_keys))

-- Docs: http://doc.pytest.org/en/latest/warnings.html

However, because warnings do not fail the test run, the tests pass automation and the warning goes unnoticed unless you run the tests locally.

We should probably configure warnings to be errors to push ourselves to act upon them. And, since the commit that changes that will fail automation if it works correctly, we'll also need to fix the warning above to get things passing. :D

	Osmose [:osmose, :mkelly] Reporter
	Comment 1 • 7 years ago

I think this is a P2 - we should do it soon, but it's not a fire or anything.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 6 years ago

Grabbing this one. Pretty sure it's a configuration change.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 6 years ago

This PR fixed the test_bugzilla logger warning: https://github.com/mozilla-services/socorro/pull/4256

	[github robot]
	Comment 5 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/fd57c440bc781dc5fafc080afcfbdda91315e521
bug 1419585 - all warnings are errors for socorro tests

This fixes the socorro tests such that all warnings are now considered
errors. This also fixes the handful of warnings that were getting kicked
up.

This doesn't fix the webapp tests--we'll do that in another PR.

https://github.com/mozilla-services/socorro/commit/cbfc96fee5ca6bfbe5c4da1fa075d719f776c858
Merge pull request #4260 from willkg/1419585-warnings

bug 1419585 - all warnings are errors for socorro tests

	[github robot]
	Comment 7 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/8a3f0b12e6803ec6c445cccad6142e274fd43532
fixes bug 1419585 - Make all warnings into errors

https://github.com/mozilla-services/socorro/commit/698db08f335c50e0c5e812d41622f2ff54b3b721
Merge pull request #4262 from willkg/1419585-warnings-2

fixes bug 1419585 - all the webapp warnings