Markus Stange [:mstange] Assignee
	Description • 7 years ago

We're not cutting out the window buttons shape with WebRender. This means that you can't see the buttons or might accidentally close your window on Windows 7.

	Markus Stange [:mstange] Assignee
	Comment 2 • 7 years ago

This patch is completely untested.

	Markus Stange [:mstange] Assignee
	Comment 5 • 7 years ago

It builds on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c857fa275f0&selectedJob=143403947

I've tested it on a  Windows 7 machine in the office and it works.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8925805 [details]
Bug 1415070 - Cut out the window button shape on Windows 7.

https://reviewboard.mozilla.org/r/196986/#review203472

::: widget/windows/nsWindow.cpp:4097
(Diff revision 3)
> +  if (mWindowButtonsRect) {
> +    wr::LayoutRect rect = wr::ToLayoutRect(*mWindowButtonsRect);
> +    nsTArray<wr::ComplexClipRegion> roundedClip;
> +    roundedClip.AppendElement(wr::ToComplexClipRegion(
> +      RoundedRect(ThebesRect(mWindowButtonsRect->ToUnknownRect()),
> +                  RectCornerRadii(0, 0, 3, 3))));

Is the bottom-radius here supposed to correspond to the clearRegion stuff below where you set mWindowButtonsRect? That clearRegion doesn't seem to be a symmetrical thing, it looks like the bottom-left corner has more clipped out than the bottom-right.

	Markus Stange [:mstange] Assignee
	Comment 7 • 7 years ago

Hmm, you're right. That code clears out a shape that looks like this:

###############
###############
###############
_##############
__############_

And that seems to be because the rest of the curve extends into the right edge of the window frame, which is not part of the our rendering area.

I'm going to extend the window buttons rect by 1px on the right side in order to match what's actually happening.

	Pulsebot
	Comment 10 • 7 years ago

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/a4632a2f8aee
Cut out the window button shape on Windows 7. r=kats

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 11 • 7 years ago

Backed out for Windows static bustage:

https://hg.mozilla.org/integration/autoland/rev/98c482aa0b42ebc35841b524fc54645492db8b6a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a4632a2f8aee8abed3c9f08f0a344724a7ac9376&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=143443318&repo=autoland

	Markus Stange [:mstange] Assignee
	Comment 12 • 7 years ago

Filed bug 1416011 about the failure. Once that lands, this can land again.

	Pulsebot
	Comment 13 • 7 years ago

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/e9a687531a09
Cut out the window button shape on Windows 7. r=kats

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e9a687531a09