Andy McKay Reporter
	Description • 7 years ago

If a user has toggled the extensions.legacy.enabled pref in an unbranded build then they should be able to run legacy extensions. Currently I think they are ignored.

I've updated https://wiki.mozilla.org/Add-ons/Firefox57 to reflect this.

Turning off signatures required is respected in unbranded builds.

	Andrew Swan [:aswan]
	Comment 1 • 7 years ago

Hm, this was supposed to be fixed in bug 1363897 but over to the releng folks who know this area.

	Ian Moody [:Kwan] (UTC+1) Assignee
	Comment 3 • 7 years ago

So, I think the above patch is enough to fix this, but try fuzzy doesn't seem able to let me select the right builds to actually test it.

	Chris AtLee [:catlee]
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8929762 [details]
Bug 1414450 - Allow ability to enable legacy extensions in unbranded builds.

https://reviewboard.mozilla.org/r/201020/#review211890

	Pulsebot
	Comment 5 • 6 years ago

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9f405fd77937
Allow ability to enable legacy extensions in unbranded builds. r=catlee

	Eliza Balazs [:ebalazs_]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9f405fd77937

	Ian Moody [:Kwan] (UTC+1) Assignee
	Comment 7 • 6 years ago

Comment on attachment 8929762 [details]
Bug 1414450 - Allow ability to enable legacy extensions in unbranded builds.

Approval Request Comment
[Feature/Bug causing the regression]:
none, but this was supposed to happen in bug 1363897

[User impact if declined]:
Users won't be able to load legacy extensions in unbranded builds

[Is this code covered by automated tests?]:
no

[Has the fix been verified in Nightly?]:
no, these mozconfigs aren't used except on beta and release, so it can't be verified on nightly

[Needs manual test from QE? If yes, steps to reproduce]:
once the builds are being made, just downloading one and checking if it can install a legacy add-on with the pref flipped

[List of other uplifts needed for the feature/fix]:
none

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
build config changes for unbranded builds only, no effect on regular builds

[String changes made/needed]:
none

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 8 • 6 years ago

Comment on attachment 8929762 [details]
Bug 1414450 - Allow ability to enable legacy extensions in unbranded builds.

Let's uplift this for 58.0b12 and verify in beta. 
Andrei can your team do the verification? Thanks.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 9 • 6 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/dba0f5124276

	Bogdan Maris, Desktop QA
	Comment 10 • 6 years ago

I tried to reproduce the issue here using DevEdition 58.0b1 on macOS 10.13 and Ubuntu 16.04 64bit but I was unable to do so. 
First I flipped 'extensions.legacy.enabled' pref to false, downloaded a legacy add-on (FireFTP, FlashGot and Firebug), dragged and dropped the .xpi file inside Firefox and the add-on successfully installed and can be used. I then tried the same thing with a build that contains the fix (DevEd 58.0b12) and I got the same exact result. At this point I can't see a difference between a build that contains the fix and one that does not.

Am I missing something here?

	Ian Moody [:Kwan] (UTC+1) Assignee
	Comment 11 • 6 years ago

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #10)
> I tried to reproduce the issue here using DevEdition 58.0b1 on macOS 10.13
> and Ubuntu 16.04 64bit but I was unable to do so. 
> First I flipped 'extensions.legacy.enabled' pref to false, downloaded a
> legacy add-on (FireFTP, FlashGot and Firebug), dragged and dropped the .xpi
> file inside Firefox and the add-on successfully installed and can be used. I
> then tried the same thing with a build that contains the fix (DevEd 58.0b12)
> and I got the same exact result. At this point I can't see a difference
> between a build that contains the fix and one that does not.
> 
> Am I missing something here?

Yes, no worries! DevEdition and Nightly already allow this pref, it's only restricted on Release and Beta.  But there are special unbranded builds of beta (and release) that this was supposed to affect.  I think they can only be found by going on treeherder and looking for the "addon" build job (I don't think they end up on https://download-installer.cdn.mozilla.net/ anywhere).
They get linked from https://wiki.mozilla.org/Add-ons/Extension_Signing#Latest_Builds but that is updated infrequently (58.0b3  is currently listed as latest beta, but that should display the pre-fix behaviour anyway).

	Bogdan Maris, Desktop QA
	Comment 12 • 6 years ago

(In reply to Ian Moody [:Kwan] (UTC+0) from comment #11)
> (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #10)
> > I tried to reproduce the issue here using DevEdition 58.0b1 on macOS 10.13
> > and Ubuntu 16.04 64bit but I was unable to do so. 
> > First I flipped 'extensions.legacy.enabled' pref to false, downloaded a
> > legacy add-on (FireFTP, FlashGot and Firebug), dragged and dropped the .xpi
> > file inside Firefox and the add-on successfully installed and can be used. I
> > then tried the same thing with a build that contains the fix (DevEd 58.0b12)
> > and I got the same exact result. At this point I can't see a difference
> > between a build that contains the fix and one that does not.
> > 
> > Am I missing something here?
> 
> Yes, no worries! DevEdition and Nightly already allow this pref, it's only
> restricted on Release and Beta.  But there are special unbranded builds of
> beta (and release) that this was supposed to affect.  I think they can only
> be found by going on treeherder and looking for the "addon" build job (I
> don't think they end up on https://download-installer.cdn.mozilla.net/
> anywhere).
> They get linked from
> https://wiki.mozilla.org/Add-ons/Extension_Signing#Latest_Builds but that is
> updated infrequently (58.0b3  is currently listed as latest beta, but that
> should display the pre-fix behaviour anyway).

Thanks Ian for the information!
I was able to reproduce the issue (I could not install legacy add-ons) on 58.0b3 downloaded from https://wiki.mozilla.org/Add-ons/Extension_Signing#Latest_Builds, but I have no issue using 58.0b12 downloaded from treeherder (https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=dba0f5124276e6baa5976bccfd579cc9369a828b). I tested across all platforms so I will go ahead and mark the tracking flag for 58 as Verified.