Jan de Mooij [:jandem] Assignee
	Description • 7 years ago

With legacy generators gone we can do this.

	Jan de Mooij [:jandem] Assignee
	Comment 1 • 7 years ago

One wrinkle is that property_iterator_next_impl can currently ThrowStopIteration. We could make it return MagicValue(JS_NO_ITER_VALUE) but returning that doesn't seem very nice.

Because that code is only there to support for-in with CCWs, this patch removes property_iterator_next and handles wrappers explicitly in js::IteratorMore.

Can you think of any problems with this? This should be green on Try.

	Tom S [:evilpie]
	Comment 2 • 7 years ago

Comment on attachment 8924556 [details] [diff] [review]
Patch

Review of attachment 8924556 [details] [diff] [review]:
-----------------------------------------------------------------

After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.

	Jan de Mooij [:jandem] Assignee
	Comment 3 • 7 years ago

Comment on attachment 8924556 [details] [diff] [review]
Patch

Changing to r? :)

	Tom S [:evilpie]
	Comment 4 • 7 years ago

Comment on attachment 8924556 [details] [diff] [review]
Patch

Review of attachment 8924556 [details] [diff] [review]:
-----------------------------------------------------------------

After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.

	Pulsebot
	Comment 5 • 7 years ago

Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73a48b92351a
Remove StopIteration object. r=evilpie

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/73a48b92351a

	Florian Scholz (Open Web Docs)
	Comment 7 • 7 years ago

Archived the StopIteration page and removed mentions of it in the main docs.
https://developer.mozilla.org/en-US/docs/Archive/Web/StopIteration

	Kohei Yoshino [:kohei]
	Comment 8 • 7 years ago

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/legacy-generator-support-has-been-removed/