Jan Honza Odvarko [:Honza] (always need-info? me) Reporter
	Description • 7 years ago

Remove the 'Flash' filter button from the toolbar and make Flash requests part of the 'Others' filter.

Honza

	Abhinav Koppula Assignee
	Comment 1 • 7 years ago

Hi Honza,
Can I work on this issue?

	Jan Honza Odvarko [:Honza] (always need-info? me) Reporter
	Comment 2 • 7 years ago

(In reply to Abhinav Koppula from comment #1)
> Hi Honza,
> Can I work on this issue?
Yes please, assigned to you!
Honza

	Abhinav Koppula Assignee
	Comment 4 • 7 years ago

Hi Honza,
I have taken a stab at this issue and have fixed the tests failing due to this change.

	Jan Honza Odvarko [:Honza] (always need-info? me) Reporter
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8925324 [details]
Bug 1413540 - Merge 'flash' filter into 'Others'.

https://reviewboard.mozilla.org/r/196486/#review201878

Looks great, thanks for the patch Abhinav!
Tested on Win10 and works for me.
R+ assuming try is green
Honza

	Pulsebot
	Comment 6 • 7 years ago

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dfd52f82973
Merge 'flash' filter into 'Others'. r=Honza

	Eliza Balazs [:ebalazs_]
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/1dfd52f82973

	Chris Mills [:cmills]
	Comment 8 • 7 years ago

I've added a note to the Network monitor page covering this:

https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Toolbar

And one to the 58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#Developer_Tools

Once 58 gets to release, I will aim to update the screenshots to not show the Flash button at all.