Closed
Bug 1413505
Opened 7 years ago
Closed 6 years ago
Apply TimeClip in intl_FormatDateTime and intl_FormatToPartsDateTime
Categories
(Core :: JavaScript: Internationalization API, enhancement, P3)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
5.27 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•7 years ago
|
||
Adds the call to TimeClip per the spec PR. I've also moved the invalid-date check into js::intl_FormatDateTime to remove a bit of code duplication and because it looks cleaner to me to pass |ClippedTime| instead of |double| values to intl_Format[ToParts]DateTime(...). All test262 from <https://github.com/tc39/test262/pull/1340> pass with the proposed changes.
|
||
Updated•7 years ago
|
Attachment #8935356 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fdae7e26f72a592cc84343e8b59563499917154
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/071076af815d Apply TimeClip in Intl.DateTimeFormat format methods. r=gandalf
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/071076af815d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•