Closed Bug 1413159 Opened 7 years ago Closed 6 years ago

Download panel glitches after removing a downloaded file

Categories

(Firefox :: Downloads Panel, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- verified
firefox60 --- verified

People

(Reporter: emilghitta, Assigned: Paolo)

References

Details

(Keywords: regression, Whiteboard: [reserve-photon-structure] [fixed by 1414244])

Attachments

(1 file)

Attached image downloads.gif
[Affected versions]:
Firefox 57.0b13 (BuildId:20171030163911)
Firefox 58.0a1  (BuildId:20171030103605)

[Affected platforms]:
- Ubuntu 16.04  64bit
- macOS 10.11.6
- Windows 10 32bit

[Steps to reproduce]:
1. Launch Firefox.
2. Access the http://testsafebrowsing.appspot.com/ webpage.
3. Click a link from the "Desktop Download Warnings" section.
4. Click the "Save File" button.
5. Click the "Remove File" option from the download panel.

[Expected result]:
The item is successfully removed and no issues occur.

[Actual result]:
The download panel is glitching right after the "Remove File" option was selected.

[Regression range]:
This seems like a regression.

I will get back to this as soon as time permits.

[Additional notes]:
For more information regarding this issue please observe the attached screencast.
Likely related to the new Photon panel behavior.
Flags: needinfo?(mdeboer)
Priority: -- → P2
Flags: needinfo?(mdeboer) → qe-verify+
Whiteboard: [reserve-photon-structure]
Priority: P2 → P3
Back with the regression.

Last good revision: af23e7b6eb9395aecf2a255316da782ca618750a
First bad revision: 35acf942df34d075d1a181db6feeec0a9904f27b

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af23e7b6eb9395aecf2a255316da782ca618750a&tochange=35acf942df34d075d1a181db6feeec0a9904f27b
Blocks: 1401991
It looks like this was a race condition in the hidePanel call, and is probably fixed now by the PanelMultiView work.

The panel should now close when using the Remove button. Emil, can you confirm this is fixed?
Depends on: 1428839
Flags: needinfo?(emil.ghitta)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This issue is verified fixed using Firefox 60.0a1 (BuildId:20180306100123) and Firefox 59.0b14 (BuildId:20180301022608) on Windows 10 64bit, macOS 10.13 and Ubuntu 16.04 64bit.

It seems that this issue was fixed by Bug 1414244.
Status: RESOLVED → VERIFIED
Depends on: 1414244
No longer depends on: 1428839
Flags: qe-verify+
Flags: needinfo?(emil.ghitta)
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure] [fixed by 1414244]
Assignee: nobody → paolo.mozmail
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: